Delete VP8 feedback mode.

webrtc/video/vie_encoder.cc

Index: webrtc/video/vie_encoder.cc
diff --git a/webrtc/video/vie_encoder.cc b/webrtc/video/vie_encoder.cc
index 4591d89599a66f71d90adfaca33d6465d0645f89..36491f21e584acc5644b89c66af81ed97b9f7e60 100644
--- a/webrtc/video/vie_encoder.cc
+++ b/webrtc/video/vie_encoder.cc
@@ -609,20 +609,6 @@ void ViEEncoder::EncodeVideoFrame(const VideoFrame& video_frame,
 
   overuse_detector_.FrameCaptured(video_frame, time_when_posted_us);
 
-  if (codec_type_ == webrtc::kVideoCodecVP8) {
-    webrtc::CodecSpecificInfo codec_specific_info;
-    codec_specific_info.codecType = webrtc::kVideoCodecVP8;
-
-    codec_specific_info.codecSpecific.VP8.hasReceivedRPSI = has_received_rpsi_;
-    codec_specific_info.codecSpecific.VP8.hasReceivedSLI = has_received_sli_;
-    codec_specific_info.codecSpecific.VP8.pictureIdRPSI = picture_id_rpsi_;
-    codec_specific_info.codecSpecific.VP8.pictureIdSLI = picture_id_sli_;
-    has_received_sli_ = false;
-    has_received_rpsi_ = false;
-
-    video_sender_.AddVideoFrame(video_frame, &codec_specific_info);
-    return;
-  }
   video_sender_.AddVideoFrame(video_frame, nullptr);
 }
 
@@ -673,6 +659,7 @@ void ViEEncoder::SendStatistics(uint32_t bit_rate, uint32_t frame_rate) {
   stats_proxy_->OnEncoderStatsUpdate(frame_rate, bit_rate);
 }
 
+// TODO(nisse): Delete.

[danilchap, 2017/03/15 09:05:32]

may be replace implementation with a noop (which would allow to remove members
like picture_id_sli_)

or do another CL between 1st and 2nd part: remove handling of rpsi/sli from
rtcp_receiver thus removing calls to this function.

[nisse-webrtc, 2017/03/15 09:29:46]

To me it seems good enough to leave these untouched until the next cl which will
delete all of the receive path for these messages. So it was intended a TODO
item to be addressed soon, but not in this cl. 

[danilchap, 2017/03/15 12:00:16]

Ok

 void ViEEncoder::OnReceivedSLI(uint8_t picture_id) {
   if (!encoder_queue_.IsCurrent()) {
     encoder_queue_.PostTask([this, picture_id] { OnReceivedSLI(picture_id); });
@@ -683,6 +670,7 @@ void ViEEncoder::OnReceivedSLI(uint8_t picture_id) {
   has_received_sli_ = true;
 }
 
+// TODO(nisse): Delete.
 void ViEEncoder::OnReceivedRPSI(uint64_t picture_id) {
   if (!encoder_queue_.IsCurrent()) {
     encoder_queue_.PostTask([this, picture_id] { OnReceivedRPSI(picture_id); });