Delete VP8 feedback mode.

webrtc/video/vie_encoder.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 591 matching lines @@
     TraceFrameDropStart();
     return;
   }
   TraceFrameDropEnd();
 
   TRACE_EVENT_ASYNC_STEP0("webrtc", "Video", video_frame.render_time_ms(),
                           "Encode");
 
   overuse_detector_.FrameCaptured(video_frame, time_when_posted_us);
 
-  if (codec_type_ == webrtc::kVideoCodecVP8) {
-    webrtc::CodecSpecificInfo codec_specific_info;
-    codec_specific_info.codecType = webrtc::kVideoCodecVP8;
-
-    codec_specific_info.codecSpecific.VP8.hasReceivedRPSI = has_received_rpsi_;
-    codec_specific_info.codecSpecific.VP8.hasReceivedSLI = has_received_sli_;
-    codec_specific_info.codecSpecific.VP8.pictureIdRPSI = picture_id_rpsi_;
-    codec_specific_info.codecSpecific.VP8.pictureIdSLI = picture_id_sli_;
-    has_received_sli_ = false;
-    has_received_rpsi_ = false;
-
-    video_sender_.AddVideoFrame(video_frame, &codec_specific_info);
-    return;
-  }
   video_sender_.AddVideoFrame(video_frame, nullptr);
 }
 
 void ViEEncoder::SendKeyFrame() {
   if (!encoder_queue_.IsCurrent()) {
     encoder_queue_.PostTask([this] { SendKeyFrame(); });
     return;
   }
   RTC_DCHECK_RUN_ON(&encoder_queue_);
   video_sender_.IntraFrameRequest(0);
@@ skipping 30 matching lines @@
     if (quality_scaler_)
       quality_scaler_->ReportDroppedFrame();
   });
 }
 
 void ViEEncoder::SendStatistics(uint32_t bit_rate, uint32_t frame_rate) {
   RTC_DCHECK(module_process_thread_checker_.CalledOnValidThread());
   stats_proxy_->OnEncoderStatsUpdate(frame_rate, bit_rate);
 }
 
+// TODO(nisse): Delete.

[danilchap, 2017/03/15 09:05:32]

may be replace implementation with a noop (which would allow to remove members
like picture_id_sli_)

or do another CL between 1st and 2nd part: remove handling of rpsi/sli from
rtcp_receiver thus removing calls to this function.

[nisse-webrtc, 2017/03/15 09:29:46]

To me it seems good enough to leave these untouched until the next cl which will
delete all of the receive path for these messages. So it was intended a TODO
item to be addressed soon, but not in this cl. 

[danilchap, 2017/03/15 12:00:16]

Ok

 void ViEEncoder::OnReceivedSLI(uint8_t picture_id) {
   if (!encoder_queue_.IsCurrent()) {
     encoder_queue_.PostTask([this, picture_id] { OnReceivedSLI(picture_id); });
     return;
   }
   RTC_DCHECK_RUN_ON(&encoder_queue_);
   picture_id_sli_ = picture_id;
   has_received_sli_ = true;
 }
 
+// TODO(nisse): Delete.
 void ViEEncoder::OnReceivedRPSI(uint64_t picture_id) {
   if (!encoder_queue_.IsCurrent()) {
     encoder_queue_.PostTask([this, picture_id] { OnReceivedRPSI(picture_id); });
     return;
   }
   RTC_DCHECK_RUN_ON(&encoder_queue_);
   picture_id_rpsi_ = picture_id;
   has_received_rpsi_ = true;
 }
 
@@ skipping 114 matching lines @@
   --scale_counter_[reason];
   source_proxy_->RequestHigherResolutionThan(current_pixel_count);
   LOG(LS_INFO) << "Scaling up resolution.";
   for (size_t i = 0; i < kScaleReasonSize; ++i) {
     LOG(LS_INFO) << "Scaled " << scale_counter_[i]
                  << " times for reason: " << (i ? "cpu" : "quality");
   }
 }
 
 }  // namespace webrtc