Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: webrtc/modules/congestion_controller/congestion_controller.cc

Issue 2753283002: Fix crash on multiple feedback messages are received on old transport. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/congestion_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc
index fdce8da4359e8d27305a7ca39661394538f8177d..ec94eeaba1cbea0a23ab65dee51e0e9124a4586b 100644
--- a/webrtc/modules/congestion_controller/congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/congestion_controller.cc
@@ -346,11 +346,14 @@ void CongestionController::OnTransportFeedback(
const rtcp::TransportFeedback& feedback) {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
transport_feedback_adapter_.OnTransportFeedback(feedback);
+ std::vector<PacketFeedback> feedback_vector =
+ transport_feedback_adapter_.GetTransportFeedbackVector();
+ if (feedback_vector.empty())
+ return;
DelayBasedBwe::Result result;
{
rtc::CritScope cs(&bwe_lock_);
- result = delay_based_bwe_->IncomingPacketFeedbackVector(
- transport_feedback_adapter_.GetTransportFeedbackVector());
+ result = delay_based_bwe_->IncomingPacketFeedbackVector(feedback_vector);
}
if (result.updated)
bitrate_controller_->OnDelayBasedBweResult(result);
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/congestion_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698