Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2753283002: Fix crash on multiple feedback messages are received on old transport. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/congestion_controller/congestion_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 if (!in_trendline_experiment_ && !in_median_slope_experiment_) { 270 if (!in_trendline_experiment_ && !in_median_slope_experiment_) {
271 LOG(LS_INFO) << "No overuse experiment enabled. Using Kalman filter."; 271 LOG(LS_INFO) << "No overuse experiment enabled. Using Kalman filter.";
272 } 272 }
273 273
274 network_thread_.DetachFromThread(); 274 network_thread_.DetachFromThread();
275 } 275 }
276 276
277 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector( 277 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
278 const std::vector<PacketFeedback>& packet_feedback_vector) { 278 const std::vector<PacketFeedback>& packet_feedback_vector) {
279 RTC_DCHECK(network_thread_.CalledOnValidThread()); 279 RTC_DCHECK(network_thread_.CalledOnValidThread());
280 RTC_DCHECK(!packet_feedback_vector.empty());
280 281
281 std::vector<PacketFeedback> sorted_packet_feedback_vector; 282 std::vector<PacketFeedback> sorted_packet_feedback_vector;
282 SortPacketFeedbackVector(packet_feedback_vector, 283 SortPacketFeedbackVector(packet_feedback_vector,
283 &sorted_packet_feedback_vector); 284 &sorted_packet_feedback_vector);
284 285
285 if (!uma_recorded_) { 286 if (!uma_recorded_) {
286 RTC_HISTOGRAM_ENUMERATION(kBweTypeHistogram, 287 RTC_HISTOGRAM_ENUMERATION(kBweTypeHistogram,
287 BweNames::kSendSideTransportSeqNum, 288 BweNames::kSendSideTransportSeqNum,
288 BweNames::kBweNamesMax); 289 BweNames::kBweNamesMax);
289 uma_recorded_ = true; 290 uma_recorded_ = true;
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) { 478 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
478 // Called from both the configuration thread and the network thread. Shouldn't 479 // Called from both the configuration thread and the network thread. Shouldn't
479 // be called from the network thread in the future. 480 // be called from the network thread in the future.
480 rate_control_.SetMinBitrate(min_bitrate_bps); 481 rate_control_.SetMinBitrate(min_bitrate_bps);
481 } 482 }
482 483
483 int64_t DelayBasedBwe::GetProbingIntervalMs() const { 484 int64_t DelayBasedBwe::GetProbingIntervalMs() const {
484 return probing_interval_estimator_.GetIntervalMs(); 485 return probing_interval_estimator_.GetIntervalMs();
485 } 486 }
486 } // namespace webrtc 487 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/congestion_controller/congestion_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698