webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc - Issue 2750783004: Add mute state field to AudioFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc

Issue 2750783004: Add mute state field to AudioFrame. (Closed)

Patch Set: Third round of comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/acm2/audio_coding_module.cc ('K') | « webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.cc ('k') | webrtc/modules/audio_mixer/audio_frame_manipulator.cc » ('j') | webrtc/modules/include/module_common_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc

diff --git a/webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc b/webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc

index 218b8be750fcaaf761fcf359e325b5b5fbf6615c..ce18d9149d0badcee0fa3a605fb466010cf8375d 100644

--- a/webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc

+++ b/webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc

@@ -129,7 +129,7 @@ TEST(AudioConferenceMixer, LargestEnergyVadActiveMixed) {

// We set the 80-th sample value since the first 80 samples may be

// modified by a ramped-in window.

- participants[i].fake_frame()->data_[80] = i;

+ participants[i].fake_frame()->mutable_data()[80] = i;

EXPECT_EQ(0, mixer->SetMixabilityStatus(&participants[i], true));

EXPECT_CALL(participants[i], GetAudioFrame(_, _))