Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_impl.cc

Issue 2750783004: Add mute state field to AudioFrame. (Closed)
Patch Set: Third round of comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/neteq_impl.cc
diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.cc b/webrtc/modules/audio_coding/neteq/neteq_impl.cc
index 786cb84aa3ed8beffb5d6d6bb9f7db8d74267afc..a60d1f04386e7500f942537289a3111f62f768c5 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_impl.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_impl.cc
@@ -11,7 +11,6 @@
#include "webrtc/modules/audio_coding/neteq/neteq_impl.h"
#include <assert.h>
-#include <memory.h> // memset
#include <algorithm>
#include <utility>
@@ -1016,16 +1015,17 @@ int NetEqImpl::GetAudioInternal(AudioFrame* audio_frame, bool* muted) {
<< ") != output_size_samples_ (" << output_size_samples_
<< ")";
// TODO(minyue): treatment of under-run, filling zeros
- memset(audio_frame->data_, 0, num_output_samples * sizeof(int16_t));
+ audio_frame->Mute();
return kSampleUnderrun;
}
// Should always have overlap samples left in the |sync_buffer_|.
RTC_DCHECK_GE(sync_buffer_->FutureLength(), expand_->overlap_length());
+ // TODO(yujo): For muted frames, this can be a copy rather than an addition.
if (play_dtmf) {
- return_value =
- DtmfOverdub(dtmf_event, sync_buffer_->Channels(), audio_frame->data_);
+ return_value = DtmfOverdub(dtmf_event, sync_buffer_->Channels(),
+ audio_frame->mutable_data());
}
// Update the background noise parameters if last operation wrote data

Powered by Google App Engine
This is Rietveld 408576698