Conversational speech tool: timing model with data access.

webrtc/modules/audio_processing/test/conversational_speech/timing.h

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_TIMING_H_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_TIMING_H_
+
+#include <memory>
+#include <string>
+#include <vector>
+
+#include "webrtc/base/array_view.h"
+
+namespace webrtc {
+namespace test {
+namespace conversational_speech {
+
+class Timing {
+ public:
+  struct Turn{
+    Turn(std::string new_speaker_name, std::string new_audiotrack_file_name,
+         int new_offset)
+        : speaker_name(new_speaker_name),
+          audiotrack_file_name(new_audiotrack_file_name),
+          offset(new_offset) {}
+    bool operator ==(const Turn &b) const;

[kwiberg-webrtc, 2017/03/21 22:35:15]

No space before ==

[AleBzk, 2017/03/22 10:07:22]

Done.

+    std::string speaker_name;
+    std::string audiotrack_file_name;
+    int offset;
+  };
+
+  Timing();
+  Timing(std::initializer_list<Turn> il);

[AleBzk, 2017/03/20 14:25:28]

I added this to familiarize with initializer list.

+  ~Timing();
+
+  // Removes all the existing turn entries.
+  void Clear();
+
+  // Appends the next turn.
+  void AppendTurn(Timing::Turn turn);
+
+  // Loads the turns from a file.
+  void Load(const std::string& timing_filepath);

[kwiberg-webrtc, 2017/03/21 22:35:15]

Would it make sense to turn this into a constructor? Or a static function that
returns a new Timing?

[AleBzk, 2017/03/22 10:07:22]

Right. I'll go for the constructor way.

+
+  // Writes the turns into a file.
+  void Save(const std::string& timing_filepath) const;
+
+  rtc::ArrayView<const Timing::Turn> turns() const;
+
+ private:
+  std::vector<Turn> turns_;
+};

[kwiberg-webrtc, 2017/03/21 22:35:15]

Hmm. Now that you no longer use unique_ptr, Timing doesn't really *do* anything.
You could replace it with free functions to save to and load from a file, and
just store the data in a std::vector<Turn>.

[AleBzk, 2017/03/22 10:07:22]

Done.

+
+}  // namespace conversational_speech
+}  // namespace test
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_TIMING_H_