Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2749803002: Enable the bayesian bitrate estimator by default. (Closed)
Patch Set: AppRTC fixes. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
index 559179e5180936e57c208be550273439a8d15c5b..f00602fa1ba0b2eda5a39c1bda7572d63575ffc1 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
@@ -119,7 +119,7 @@ TEST_F(DelayBasedBweTest, ProbeDetectionSlowerArrivalHighBitrate) {
TEST_F(DelayBasedBweTest, GetProbingInterval) {
int64_t default_interval_ms = bitrate_estimator_->GetProbingIntervalMs();
EXPECT_GT(default_interval_ms, 0);
- CapacityDropTestHelper(1, true, 567, 0);
+ CapacityDropTestHelper(1, true, 333, 0);
int64_t interval_ms = bitrate_estimator_->GetProbingIntervalMs();
EXPECT_GT(interval_ms, 0);
EXPECT_NE(interval_ms, default_interval_ms);
@@ -134,23 +134,23 @@ TEST_F(DelayBasedBweTest, RateIncreaseReordering) {
}
TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(1288);
}
TEST_F(DelayBasedBweTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 567, 0);
+ CapacityDropTestHelper(1, false, 333, 0);
}
TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
- CapacityDropTestHelper(1, false, 200, 30000);
+ CapacityDropTestHelper(1, false, 300, 30000);
}
TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 733, -30000);
+ CapacityDropTestHelper(1, false, 300, -30000);
}
TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 567, 0);
+ CapacityDropTestHelper(1, true, 333, 0);
}
TEST_F(DelayBasedBweTest, TestTimestampGrouping) {
@@ -172,37 +172,6 @@ TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) {
TestWrappingHelper(10 * 64);
}
-class DelayBasedBweExperimentTest : public DelayBasedBweTest {
- public:
- DelayBasedBweExperimentTest()
- : override_field_trials_("WebRTC-ImprovedBitrateEstimate/Enabled/") {
- bitrate_estimator_.reset(new DelayBasedBwe(nullptr, &clock_));
- }
-
- private:
- test::ScopedFieldTrials override_field_trials_;
-};
-
-TEST_F(DelayBasedBweExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1288);
-}
-
-TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 333, 0);
-}
-
-TEST_F(DelayBasedBweExperimentTest, CapacityDropPosOffsetChange) {
- CapacityDropTestHelper(1, false, 300, 30000);
-}
-
-TEST_F(DelayBasedBweExperimentTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 300, -30000);
-}
-
-TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 333, 0);
-}
-
class DelayBasedBweTrendlineExperimentTest : public DelayBasedBweTest {
public:
DelayBasedBweTrendlineExperimentTest()
@@ -215,11 +184,11 @@ class DelayBasedBweTrendlineExperimentTest : public DelayBasedBweTest {
};
TEST_F(DelayBasedBweTrendlineExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(1288);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 600, 0);
+ CapacityDropTestHelper(1, false, 433, 0);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropPosOffsetChange) {
@@ -227,11 +196,11 @@ TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropPosOffsetChange) {
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 1267, -30000);
+ CapacityDropTestHelper(1, false, 767, -30000);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 600, 0);
+ CapacityDropTestHelper(1, true, 433, 0);
}
class DelayBasedBweMedianSlopeExperimentTest : public DelayBasedBweTest {
@@ -246,11 +215,11 @@ class DelayBasedBweMedianSlopeExperimentTest : public DelayBasedBweTest {
};
TEST_F(DelayBasedBweMedianSlopeExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(1288);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 600, 0);
+ CapacityDropTestHelper(1, false, 367, 0);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropPosOffsetChange) {
@@ -258,11 +227,11 @@ TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropPosOffsetChange) {
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 1267, -30000);
+ CapacityDropTestHelper(1, false, 767, -30000);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 600, 0);
+ CapacityDropTestHelper(1, true, 367, 0);
}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698