Conversational Speech generator, unit test

webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn

Index: webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn
diff --git a/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn b/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn
index 5301cb209e2d9510c8ff59913a0e7ff2eb25bc77..d0cb1e7e7e05eafe2587fc6e8f8ff538b96ce768 100644
--- a/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn
+++ b/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn
@@ -6,26 +6,50 @@
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
-import("../../../../webrtc.gni")
+import("//webrtc/webrtc.gni")
 
 group("conversational_speech") {
   testonly = true
   deps = [
-    ":convspeech_gen",
+    ":conversational_speech_generator",
+    ":conversational_speech_generator_unittest",
   ]
 }
 
-rtc_executable("convspeech_gen") {
+rtc_executable("conversational_speech_generator") {
   testonly = true
   sources = [
-    "convspeech_gen.cc",
-    "settings.cc",
-    "settings.h",
+    "generator.cc",
   ]
   deps = [
+    ":lib",
     "//third_party/gflags",
     "//webrtc/base:rtc_base_approved",
     "//webrtc/test:test_support",
   ]
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
+}  # bin
+
+rtc_static_library("lib") {
+  testonly = true
+  sources = [
+    "config.cc",
+    "config.h",
+  ]
+  deps = []
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+}  # lib
+
+rtc_test("conversational_speech_generator_unittest") {

[kjellander (google.com), 2017/03/23 06:24:36]

Adding a test like this doesn't make it run. Please add "generator_unittest.cc"
to modules_unittests instead and delete this rtc_test target. We need to keep
the number of tests down since it's a lot of overhead introducing new ones due
to many different systems are involved in their configuration.

+  testonly = true
+  deps = [
+    ":lib",
+    "//testing/gtest",
+    "//webrtc//base:rtc_base_tests_main",
+    "//webrtc/test:test_support",
+  ]
+  sources = [
+    "generator_unittest.cc",
+  ]
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
 }