Pass ownership of candidate to PeerConnection::OnIceCandidate

webrtc/api/peerconnectioninterface.h

Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index b346783bb37048699b95e256026b8bf1a92bb08e..bd9d93ce837fc5e82c434c7edab98d5a81bff6f5 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -801,7 +801,8 @@ class PeerConnectionObserver {
       PeerConnectionInterface::IceGatheringState new_state) = 0;
 
   // A new ICE candidate has been gathered.
-  virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
+  virtual void OnIceCandidate(

[joachim, 2017/03/19 22:32:22]

The better solution would be to keep the old version of the method and call it
from the new one by default so existing implementatios wouldn't need to be
changed.
This however requires to add "using PeerConnectionObserver::OnIceCandidate" to
all subclasses (to avoid hiding the new API) - which imho doesn't make it easier
to migrade to the new API.

+      rtc::scoped_refptr<IceCandidateInterface> candidate) = 0;
 
   // Ice candidates have been removed.
   // TODO(honghaiz): Make this a pure virtual method when all its subclasses