Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webrtc/pc/webrtcsession.h

Issue 2748253003: Pass ownership of candidate to PeerConnection::OnIceCandidate (Closed)
Patch Set: Pass ownership through std::unique_ptr Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 class IceObserver { 81 class IceObserver {
82 public: 82 public:
83 IceObserver() {} 83 IceObserver() {}
84 // Called any time the IceConnectionState changes 84 // Called any time the IceConnectionState changes
85 virtual void OnIceConnectionStateChange( 85 virtual void OnIceConnectionStateChange(
86 PeerConnectionInterface::IceConnectionState new_state) {} 86 PeerConnectionInterface::IceConnectionState new_state) {}
87 // Called any time the IceGatheringState changes 87 // Called any time the IceGatheringState changes
88 virtual void OnIceGatheringChange( 88 virtual void OnIceGatheringChange(
89 PeerConnectionInterface::IceGatheringState new_state) {} 89 PeerConnectionInterface::IceGatheringState new_state) {}
90 // New Ice candidate have been found. 90 // New Ice candidate have been found.
91 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0; 91 virtual void OnIceCandidate(
92 std::unique_ptr<IceCandidateInterface> candidate) = 0;
92 93
93 // Some local ICE candidates have been removed. 94 // Some local ICE candidates have been removed.
94 virtual void OnIceCandidatesRemoved( 95 virtual void OnIceCandidatesRemoved(
95 const std::vector<cricket::Candidate>& candidates) = 0; 96 const std::vector<cricket::Candidate>& candidates) = 0;
96 97
97 // Called whenever the state changes between receiving and not receiving. 98 // Called whenever the state changes between receiving and not receiving.
98 virtual void OnIceConnectionReceivingChange(bool receiving) {} 99 virtual void OnIceConnectionReceivingChange(bool receiving) {}
99 100
100 protected: 101 protected:
101 ~IceObserver() {} 102 ~IceObserver() {}
(...skipping 530 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 633
633 #ifdef HAVE_QUIC 634 #ifdef HAVE_QUIC
634 std::unique_ptr<QuicDataTransport> quic_data_transport_; 635 std::unique_ptr<QuicDataTransport> quic_data_transport_;
635 #endif // HAVE_QUIC 636 #endif // HAVE_QUIC
636 637
637 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession); 638 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession);
638 }; 639 };
639 } // namespace webrtc 640 } // namespace webrtc
640 641
641 #endif // WEBRTC_PC_WEBRTCSESSION_H_ 642 #endif // WEBRTC_PC_WEBRTCSESSION_H_
OLDNEW
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698