webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc - Issue 2747863003: Loosening the coupling between WebRTC and //third_party/protobuf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

Issue 2747863003: Loosening the coupling between WebRTC and //third_party/protobuf (Closed)

Patch Set: Adding other deps to protobuf_utils Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h ('k') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

index 7770e65a269ec8e246d982e647f9ad3bc2d23f23..32724bac8a6d41660349b602deddd08a33235209 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

@@ -12,6 +12,7 @@

#include "webrtc/base/checks.h"

#include "webrtc/base/ignore_wundef.h"

+#include "webrtc/base/protobuf_utils.h"

#ifdef WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP

RTC_PUSH_IGNORING_WUNDEF()

@@ -34,7 +35,7 @@ using audio_network_adaptor::debug_dump::EncoderRuntimeConfig;

void DumpEventToFile(const Event& event, FileWrapper* dump_file) {

RTC_CHECK(dump_file->is_open());

- std::string dump_data;

+ ProtoString dump_data;

event.SerializeToString(&dump_data);

int32_t size = event.ByteSize();

dump_file->Write(&size, sizeof(size));