webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h - Issue 2747863003: Loosening the coupling between WebRTC and //third_party/protobuf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

Issue 2747863003: Loosening the coupling between WebRTC and //third_party/protobuf (Closed)

Patch Set: Adding other deps to protobuf_utils Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/audio_coding/BUILD.gn ('k') | webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

index 338a3657e28ec75ba5748f7047e3f2b0332ab834..9a2c4590aeb7f1cc65b7b88f8d409b298f01a43b 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

@@ -16,6 +16,7 @@

#include <vector>

#include "webrtc/base/constructormagic.h"

+#include "webrtc/base/protobuf_utils.h"

#include "webrtc/modules/audio_coding/audio_network_adaptor/controller.h"

namespace webrtc {

@@ -49,7 +50,7 @@ class ControllerManagerImpl final : public ControllerManager {

};

static std::unique_ptr<ControllerManager> Create(

- const std::string& config_string,

+ const ProtoString& config_string,

size_t num_encoder_channels,

rtc::ArrayView<const int> encoder_frame_lengths_ms,

int min_encoder_bitrate_bps,