Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_parser.cc

Issue 2747863003: Loosening the coupling between WebRTC and //third_party/protobuf (Closed)
Patch Set: Adding protobuf dep to DEPS file Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc b/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
index a806b3db0e663149c1157a7833fb306304210847..50b6214ebe08c57629e35056f315d2bc4cfecbc4 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
@@ -20,6 +20,7 @@
#include "webrtc/base/checks.h"
#include "webrtc/base/logging.h"
+//#include "webrtc/base/protobuf_utils.h"
#include "webrtc/call/call.h"
#include "webrtc/logging/rtc_event_log/rtc_event_log.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@@ -125,10 +126,11 @@ std::pair<uint64_t, bool> ParseVarInt(std::istream& stream) {
return std::make_pair(varint, false);
}
+// TODO(mbonadei): Move google::protobuf::RepeatedPtrField to protobuf_utils.h
void GetHeaderExtensions(
std::vector<RtpExtension>* header_extensions,
const google::protobuf::RepeatedPtrField<rtclog::RtpHeaderExtension>&
- proto_header_extensions) {
+ proto_header_extensions) {
header_extensions->clear();
for (auto& p : proto_header_extensions) {
RTC_CHECK(p.has_name());

Powered by Google App Engine
This is Rietveld 408576698