Loosening the coupling between WebRTC and //third_party/protobuf

webrtc/base/BUILD.gn

Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index bf6d989027a0ba4757fad120b3523246668a66cb..76e4fa8721c1127a4929e8934981107e397253a2 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -79,6 +79,14 @@ if (!rtc_build_ssl) {
   }
 }
 
+# TODO(mbonadei): wrap into an if to check if rtc_enable_protobuf is true?

[kjellander_webrtc, 2017/03/14 21:28:05]

Yes, put this inside an if(rtc_enable_protobuf) condition.

[mbonadei, 2017/03/15 10:08:05]

Done.

+source_set("protobuf_utils") {
+  sources = [
+    "protobuf_utils.h",
+  ]
+  include_dirs = [ "//third_party/protobuf/src" ]

[kjellander_webrtc, 2017/03/14 21:28:05]

I think you should replace this with a deps entry for
//third_party/protobuf:protobuf_lite

that will give you the include dir added via
https://cs.chromium.org/chromium/src/third_party/protobuf/BUILD.gn?rcl=761f60...
but also necessary defines (it seems).

[mbonadei, 2017/03/15 10:08:05]

Done.

+}
+
 # The subset of rtc_base approved for use outside of libjingle.
 rtc_static_library("rtc_base_approved") {
   defines = []