Loosening the coupling between WebRTC and //third_party/protobuf

webrtc/base/protobuf_utils.h

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include <string>
+
+#ifndef WEBRTC_BASE_PROTOBUF_UTILS_H_
+#define WEBRTC_BASE_PROTOBUF_UTILS_H_
+
+#include "third_party/protobuf/src/google/protobuf/message_lite.h"
+// #include "third_party/protobuf/src/google/protobuf/repeated_field.h"

[mbonadei, 2017/03/14 16:07:35]

I am struggling with this one.

I need to include this in order to remove the comment from line
22 and remove the reference to google::protobuf::RepeatedPtrField
from webrtc/logging/rtc_event_log/rtc_event_log_parser.cc.

But when I try I get this error:

[...]
error: cannot use typeid with -fno-rtti
    T* t = new (AllocateAligned(RTTI_TYPE_ID(T), sizeof(T))) T(arg);
[...]
/third_party/protobuf/src/google/protobuf/arena.h:162:30: note: expanded from
macro 'RTTI_TYPE_ID'

[kjellander_webrtc, 2017/03/14 21:28:05]

I think you can solve this by depending on //third_party/protobuf:protobuf_lite
in the protobuf_utils GN target (instead of just including the src dir).
That way, you'll get this config:
https://cs.chromium.org/chromium/src/third_party/protobuf/BUILD.gn?rcl=761f60...
which might solve this error.

[mbonadei, 2017/03/15 10:08:05]

Done.

+
+typedef std::string ProtoString;
+
+using google::protobuf::MessageLite;
+// using google::protobuf::RepeatedPtrField;
+
+#endif  // WEBRTC_BASE_PROTOBUF_UTILS_H_