Loosening the coupling between WebRTC and //third_party/protobuf

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 61 matching lines @@
 }
 
 if (!rtc_build_ssl) {
   config("external_ssl_library") {
     assert(rtc_ssl_root != "",
            "You must specify rtc_ssl_root when rtc_build_ssl==0.")
     include_dirs = [ rtc_ssl_root ]
   }
 }
 
+# TODO(mbonadei): wrap into an if to check if rtc_enable_protobuf is true?

[kjellander_webrtc, 2017/03/14 21:28:05]

Yes, put this inside an if(rtc_enable_protobuf) condition.

[mbonadei, 2017/03/15 10:08:05]

Done.

+source_set("protobuf_utils") {
+  sources = [
+    "protobuf_utils.h",
+  ]
+  include_dirs = [ "//third_party/protobuf/src" ]

[kjellander_webrtc, 2017/03/14 21:28:05]

I think you should replace this with a deps entry for
//third_party/protobuf:protobuf_lite

that will give you the include dir added via
https://cs.chromium.org/chromium/src/third_party/protobuf/BUILD.gn?rcl=761f60...
but also necessary defines (it seems).

[mbonadei, 2017/03/15 10:08:05]

Done.

+}
+
 # The subset of rtc_base approved for use outside of libjingle.
 rtc_static_library("rtc_base_approved") {
   defines = []
   libs = []
   deps = []
   all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
 
   sources = [
     "array_view.h",
     "arraysize.h",
@@ skipping 789 matching lines @@
 
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }