Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2747123007: Test submission of complete AEC-dump refactoring. (Closed)
Patch Set: Changed interface and build structure after reviewer comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index ab924b75343e5d9c086e6a689ca7726b6e830c3d..e144f187f7ccf6cec0192ebe307bf60e948bd3a5 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -29,6 +29,7 @@ namespace webrtc {
struct AecCore;
+class AecDump;
class AudioFrame;
class NonlinearBeamformer;
@@ -447,32 +448,12 @@ class AudioProcessing {
virtual void set_delay_offset_ms(int offset) = 0;
virtual int delay_offset_ms() const = 0;
- // Starts recording debugging information to a file specified by |filename|,
- // a NULL-terminated string. If there is an ongoing recording, the old file
- // will be closed, and recording will continue in the newly specified file.
- // An already existing file will be overwritten without warning. A maximum
- // file size (in bytes) for the log can be specified. The logging is stopped
- // once the limit has been reached. If max_log_size_bytes is set to a value
- // <= 0, no limit will be used.
- static const size_t kMaxFilenameSize = 1024;
- virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
- int64_t max_log_size_bytes) = 0;
-
- // Same as above but uses an existing file handle. Takes ownership
- // of |handle| and closes it at StopDebugRecording().
- virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
-
- // TODO(ivoc): Remove this function after Chrome stops using it.
- virtual int StartDebugRecording(FILE* handle) = 0;
-
- // Same as above but uses an existing PlatformFile handle. Takes ownership
- // of |handle| and closes it at StopDebugRecording().
- // TODO(xians): Make this interface pure virtual.
- virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) = 0;
+ // TODO(aleloi): doc
+ virtual void StartDebugRecording(std::unique_ptr<AecDump> aec_dump) = 0;
// Stops recording debugging information, and closes the file. Recording
// cannot be resumed in the same file (without overwriting it).
- virtual int StopDebugRecording() = 0;
+ virtual void StopDebugRecording() = 0;
// Use to send UMA histograms at end of a call. Note that all histogram
// specific member variables are reset.
« no previous file with comments | « webrtc/modules/audio_processing/include/aec_dump.cc ('k') | webrtc/modules/audio_processing/include/mock_audio_processing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698