Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: webrtc/modules/audio_processing/BUILD.gn

Issue 2747123007: Test submission of complete AEC-dump refactoring. (Closed)
Patch Set: Changed interface and build structure after reviewer comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/modules/audio_processing/aec_dump/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/BUILD.gn
diff --git a/webrtc/modules/audio_processing/BUILD.gn b/webrtc/modules/audio_processing/BUILD.gn
index 36f55756f825fe0b719d6a6c0d0ca1563ade5c65..5f6c527b9e209f15c995a1fa3c179779f62a7e64 100644
--- a/webrtc/modules/audio_processing/BUILD.gn
+++ b/webrtc/modules/audio_processing/BUILD.gn
@@ -229,6 +229,7 @@ rtc_static_library("audio_processing") {
defines = []
deps = [
+ ":aec_dump_interface",
"../..:webrtc_common",
"../../audio/utility:audio_frame_operations",
"../../base:gtest_prod",
@@ -248,11 +249,6 @@ rtc_static_library("audio_processing") {
defines += [ "WEBRTC_UNTRUSTED_DELAY" ]
}
- if (rtc_enable_protobuf) {
- defines += [ "WEBRTC_AUDIOPROC_DEBUG_DUMP" ]
- deps += [ ":audioproc_debug_proto" ]
- }
-
if (rtc_enable_intelligibility_enhancer) {
defines += [ "WEBRTC_INTELLIGIBILITY_ENHANCER=1" ]
sources += [
@@ -301,6 +297,21 @@ rtc_static_library("audio_processing") {
]
}
+rtc_source_set("aec_dump_interface") {
+ # Includes audio_processing.h. TODO(aleloi): add a dependency for
+ # that when the header is not part of :audio_processing.
+ check_includes = false
+
+ sources = [
+ "include/aec_dump.cc",
+ "include/aec_dump.h",
+ ]
+
+ deps = [
+ # "../../base:rtc_base_approved",
+ ]
+}
+
rtc_source_set("audio_processing_c") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
@@ -565,6 +576,10 @@ if (rtc_include_tests) {
":audioproc_debug_proto",
":audioproc_protobuf_utils",
":audioproc_unittest_proto",
+ "../../base:rtc_task_queue",
+ "aec_dump",
+ "aec_dump:aec_dump_impl",
+ "aec_dump:aec_dump_unittests",
]
sources += [
"aec3/adaptive_fir_filter_unittest.cc",
@@ -703,10 +718,13 @@ if (rtc_include_tests) {
":audioproc_protobuf_utils",
":audioproc_test_utils",
"../../base:rtc_base_approved",
+ "../../base:rtc_task_queue",
"../../common_audio:common_audio",
"../../system_wrappers",
"../../system_wrappers:system_wrappers_default",
"../../test:test_support",
+ "aec_dump",
+ "aec_dump:aec_dump_impl",
"//testing/gtest",
"//third_party/gflags:gflags",
]
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/modules/audio_processing/aec_dump/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698