Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: webrtc/modules/audio_processing/BUILD.gn

Issue 2747123007: Test submission of complete AEC-dump refactoring. (Closed)
Patch Set: Refactoring introduced bug: DCHECK(moved uptr) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/BUILD.gn
diff --git a/webrtc/modules/audio_processing/BUILD.gn b/webrtc/modules/audio_processing/BUILD.gn
index 36f55756f825fe0b719d6a6c0d0ca1563ade5c65..c6856259a49a9126300f13b9381eb9592430e8c2 100644
--- a/webrtc/modules/audio_processing/BUILD.gn
+++ b/webrtc/modules/audio_processing/BUILD.gn
@@ -233,7 +233,13 @@ rtc_static_library("audio_processing") {
"../../audio/utility:audio_frame_operations",
"../../base:gtest_prod",
"../audio_coding:isac",
+ "aec_dumper",
]
+ if (rtc_enable_protobuf) {
+ deps += [ "aec_dumper:aec_dumper_impl" ]
+ } else {
+ deps += [ "aec_dumper:aec_dumper_no_pb" ]
+ }
public_deps = [
":audio_processing_c",
]
@@ -248,11 +254,6 @@ rtc_static_library("audio_processing") {
defines += [ "WEBRTC_UNTRUSTED_DELAY" ]
}
- if (rtc_enable_protobuf) {
- defines += [ "WEBRTC_AUDIOPROC_DEBUG_DUMP" ]
- deps += [ ":audioproc_debug_proto" ]
- }
-
if (rtc_enable_intelligibility_enhancer) {
defines += [ "WEBRTC_INTELLIGIBILITY_ENHANCER=1" ]
sources += [
@@ -526,6 +527,7 @@ if (rtc_include_tests) {
"../../base:gtest_prod",
"../../base:rtc_base",
"../../base:rtc_base_approved",
+ "../../base:rtc_task_queue",
"../../common_audio:common_audio",
"../../system_wrappers:system_wrappers",
"../../test:test_support",
@@ -565,6 +567,7 @@ if (rtc_include_tests) {
":audioproc_debug_proto",
":audioproc_protobuf_utils",
":audioproc_unittest_proto",
+ "aec_dumper:aec_dumper_unittests",
]
sources += [
"aec3/adaptive_fir_filter_unittest.cc",
@@ -703,6 +706,7 @@ if (rtc_include_tests) {
":audioproc_protobuf_utils",
":audioproc_test_utils",
"../../base:rtc_base_approved",
+ "../../base:rtc_task_queue",
"../../common_audio:common_audio",
"../../system_wrappers",
"../../system_wrappers:system_wrappers_default",

Powered by Google App Engine
This is Rietveld 408576698