webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc - Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&] (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc ('k') | webrtc/tools/event_log_visualizer/analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

index fff8ee303c4664cfbe418dc9af70defc585455ca..075564d69ac777f5a85e417aaa5027609ae6e122 100644

--- a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

@@ -104,8 +104,9 @@ TEST_F(AudioEncoderCopyRedTest, CheckTargetAudioBitratePropagation) {

}

TEST_F(AudioEncoderCopyRedTest, CheckPacketLossFractionPropagation) {

- EXPECT_CALL(*mock_encoder_, OnReceivedUplinkPacketLossFraction(0.5));

- red_->OnReceivedUplinkPacketLossFraction(0.5);

+ EXPECT_CALL(*mock_encoder_,

+ OnReceivedUplinkPacketLossFraction(rtc::Optional<float>(0.5f)));

+ red_->OnReceivedUplinkPacketLossFraction(rtc::Optional<float>(0.5f));

}

// Checks that the an Encode() call is immediately propagated to the speech

« no previous file with comments | « webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc ('k') | webrtc/tools/event_log_visualizer/analyzer.cc » ('j') | no next file with comments »