webrtc/modules/audio_coding/codecs/audio_encoder.cc - Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/audio_encoder.cc

Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&] (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/audio_encoder.cc

diff --git a/webrtc/modules/audio_coding/codecs/audio_encoder.cc b/webrtc/modules/audio_coding/codecs/audio_encoder.cc

index 9e0cf4a510f3b3f7f748de449a53efedfbd2c220..5b8a5962c2032c2d2f82ba10793036a582cdd122 100644

--- a/webrtc/modules/audio_coding/codecs/audio_encoder.cc

+++ b/webrtc/modules/audio_coding/codecs/audio_encoder.cc

@@ -74,7 +74,7 @@ bool AudioEncoder::EnableAudioNetworkAdaptor(const std::string& config_string,

void AudioEncoder::DisableAudioNetworkAdaptor() {}

void AudioEncoder::OnReceivedUplinkPacketLossFraction(

- float uplink_packet_loss_fraction) {}

+ const rtc::Optional<float>& uplink_packet_loss_fraction) {}

void AudioEncoder::OnReceivedTargetAudioBitrate(int target_audio_bitrate_bps) {

OnReceivedUplinkBandwidth(target_audio_bitrate_bps, rtc::Optional<int64_t>());