Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc

Issue 2745523002: Add FullStack test for simulcast screenshare mode. (Closed)
Patch Set: Fix memory corruption: VP8EncoderFactory was deleted twice Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc
index af073cd370f70c84b9cf56b61531a4550cacfa52..4cacabf442f7393e45f07005b6740c7a64c85c71 100644
--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc
@@ -30,6 +30,7 @@ SimulcastRateAllocator::SimulcastRateAllocator(
void SimulcastRateAllocator::OnTemporalLayersCreated(int simulcast_id,
TemporalLayers* layers) {
RTC_DCHECK(temporal_layers_.find(simulcast_id) == temporal_layers_.end());
+ RTC_DCHECK(layers != nullptr);
stefan-webrtc 2017/03/09 14:07:46 I think you can omit nullptr
ilnik 2017/03/09 14:34:35 Done.
temporal_layers_[simulcast_id] = layers;
}

Powered by Google App Engine
This is Rietveld 408576698