Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: webrtc/video/full_stack_tests.cc

Issue 2745523002: Add FullStack test for simulcast screenshare mode. (Closed)
Patch Set: Apply missing parts of the patch Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <stdio.h> 10 #include <stdio.h>
11 11
12 #include "webrtc/test/field_trial.h"
12 #include "webrtc/test/gtest.h" 13 #include "webrtc/test/gtest.h"
13 #include "webrtc/video/video_quality_test.h" 14 #include "webrtc/video/video_quality_test.h"
14 15
15 namespace webrtc { 16 namespace webrtc {
16 17
17 static const int kFullStackTestDurationSecs = 45; 18 static const int kFullStackTestDurationSecs = 45;
18 19
19 class FullStackTest : public VideoQualityTest { 20 class FullStackTest : public VideoQualityTest {
20 public: 21 public:
21 void RunTest(const VideoQualityTest::Params &params) { 22 void RunTest(const VideoQualityTest::Params &params) {
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 VideoQualityTest::Params screenshare; 302 VideoQualityTest::Params screenshare;
302 screenshare.call.send_side_bwe = true; 303 screenshare.call.send_side_bwe = true;
303 screenshare.video = {true, 1850, 1110, 5, 50000, 200000, 2000000, false, 304 screenshare.video = {true, 1850, 1110, 5, 50000, 200000, 2000000, false,
304 "VP8", 2, 1, 400000, false, false, "", ""}; 305 "VP8", 2, 1, 400000, false, false, "", ""};
305 screenshare.screenshare = {true, 10}; 306 screenshare.screenshare = {true, 10};
306 screenshare.analyzer = {"screenshare_slides", 0.0, 0.0, 307 screenshare.analyzer = {"screenshare_slides", 0.0, 0.0,
307 kFullStackTestDurationSecs}; 308 kFullStackTestDurationSecs};
308 RunTest(screenshare); 309 RunTest(screenshare);
309 } 310 }
310 311
312 TEST_F(FullStackTest, ScreenshareSlidesVP8_2TL_Simulcast) {
313 test::ScopedFieldTrials field_trial("WebRTC-SimulcastScreenshare/Enabled/");
314
315 VideoQualityTest::Params screenshare;
316 screenshare.call.send_side_bwe = true;
317 screenshare.screenshare = {true, 10};
318 screenshare.video = {true, 1850, 1110, 5, 800000, 2500000,
319 2500000, false, "VP8", 3, 1, 400000,
320 false, false, "", ""};
321 screenshare.analyzer = {"screenshare_slides_simulcast", 0.0, 0.0,
322 kFullStackTestDurationSecs};
323 VideoQualityTest::Params screenshare_params_high;
324 screenshare_params_high.video = {true, 1850, 1110, 5, 800000, 2500000,
325 2500000, false, "VP8", 3, 0, 400000,
326 false, false, "", ""};
ilnik 2017/03/09 11:20:23 Erik, does it make sense to make 3 temporal layers
sprang_webrtc 2017/03/09 11:43:48 Yes, this is by design. The low stream keeps the c
327 VideoQualityTest::Params screenshare_params_low;
328 screenshare_params_low.video = {true, 1850, 1110, 5, 50000, 200000,
329 2000000, false, "VP8", 2, 0, 400000,
330 false, false, "", ""};
331
332 std::vector<VideoStream> streams = {
333 DefaultVideoStream(screenshare_params_low),
334 DefaultVideoStream(screenshare_params_high)};
335 screenshare.ss = {streams, 1, 1, 0};
336 RunTest(screenshare);
337 }
338
311 TEST_F(FullStackTest, ScreenshareSlidesVP8_2TL_Scroll) { 339 TEST_F(FullStackTest, ScreenshareSlidesVP8_2TL_Scroll) {
312 VideoQualityTest::Params config; 340 VideoQualityTest::Params config;
313 config.call.send_side_bwe = true; 341 config.call.send_side_bwe = true;
314 config.video = {true, 1850, 1110 / 2, 5, 50000, 200000, 2000000, false, 342 config.video = {true, 1850, 1110 / 2, 5, 50000, 200000, 2000000, false,
315 "VP8", 2, 1, 400000, false, false, "", ""}; 343 "VP8", 2, 1, 400000, false, false, "", ""};
316 config.screenshare = {true, 10, 2}; 344 config.screenshare = {true, 10, 2};
317 config.analyzer = {"screenshare_slides_scrolling", 0.0, 0.0, 345 config.analyzer = {"screenshare_slides_scrolling", 0.0, 0.0,
318 kFullStackTestDurationSecs}; 346 kFullStackTestDurationSecs};
319 RunTest(config); 347 RunTest(config);
320 } 348 }
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low), 586 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low),
559 DefaultVideoStream(video_params_medium), 587 DefaultVideoStream(video_params_medium),
560 DefaultVideoStream(video_params_high)}; 588 DefaultVideoStream(video_params_high)};
561 large_room.num_thumbnails = 50; 589 large_room.num_thumbnails = 50;
562 large_room.ss = {streams, 2, 1, 0}; 590 large_room.ss = {streams, 2, 1, 0};
563 RunTest(large_room); 591 RunTest(large_room);
564 } 592 }
565 593
566 594
567 } // namespace webrtc 595 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc ('k') | webrtc/video/video_quality_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698