webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h - Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h

Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h

index da4b0317f6e450d2836394315760f458015f5011..1661cd3a4d58d46c07e91cbd77cddee7b984516b 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h

@@ -27,9 +27,8 @@ class DebugDumpWriter {

virtual ~DebugDumpWriter() = default;

- virtual void DumpEncoderRuntimeConfig(

- const AudioNetworkAdaptor::EncoderRuntimeConfig& config,

- int64_t timestamp) = 0;

+ virtual void DumpEncoderRuntimeConfig(const AudioEncoderRuntimeConfig& config,

+ int64_t timestamp) = 0;

virtual void DumpNetworkMetrics(const Controller::NetworkMetrics& metrics,

int64_t timestamp) = 0;