Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h

Issue 2745193002: iOS: Add new RTCVideoSource interface (Closed)
Patch Set: Naming convention and remove unnecessary code. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h
new file mode 100644
index 0000000000000000000000000000000000000000..74c4e9e5f826239f47d3b9a61e5bfa59aba60c40
--- /dev/null
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h
@@ -0,0 +1,29 @@
+/*
+ * Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import <WebRTC/RTCVideoFrame.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+RTC_EXPORT
+
+@protocol RTCVideoCapturerDelegate;
+
+@interface RTCVideoCapturer : NSObject
+- (instancetype)initWithDelegate:(__weak id<RTCVideoCapturerDelegate>)delegate;
daniela-webrtc 2017/03/20 14:23:10 We don't need to enforce invokers of the method to
magjed_webrtc 2017/03/27 12:35:11 Done.
+@property(nonatomic, readonly) id<RTCVideoCapturerDelegate> delegate;
daniela-webrtc 2017/03/20 14:23:10 Do we need to expose the delegate as property here
daniela-webrtc 2017/03/20 15:18:30 Ah just saw that we need it for subclassing. In t
magjed_webrtc 2017/03/27 12:35:11 Done.
+@end
+
+@protocol RTCVideoCapturerDelegate
daniela-webrtc 2017/03/20 14:23:10 Nit: It's common to declare the protocol on top of
magjed_webrtc 2017/03/27 12:35:11 Done.
+- (void)capturer:(RTCVideoCapturer*)capturer
daniela-webrtc 2017/03/20 14:23:10 Nit: RTCVideoCapturer* -> RTCVideoCapturer *
magjed_webrtc 2017/03/27 12:35:11 Done.
+ didCaptureVideoFrame:(RTCVideoFrame*)frame;
daniela-webrtc 2017/03/20 14:23:10 Same spacing comment
magjed_webrtc 2017/03/27 12:35:11 Done.
+@end
+
+NS_ASSUME_NONNULL_END

Powered by Google App Engine
This is Rietveld 408576698