webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h - Issue 2745193002: iOS: Add new RTCVideoSource interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h

Issue 2745193002: iOS: Add new RTCVideoSource interface (Closed)

Patch Set: Address comments and clang-format Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h ('K') | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoSource.h » ('j') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoSource.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.

	3 *

	4 * Use of this source code is governed by a BSD-style license

	5 * that can be found in the LICENSE file in the root of the source

	6 * tree. An additional intellectual property rights grant can be found

	7 * in the file PATENTS. All contributing project authors may

	8 * be found in the AUTHORS file in the root of the source tree.

	9 */

	10

	11 #import <WebRTC/RTCVideoFrame.h>

	12

	13 NS_ASSUME_NONNULL_BEGIN

	14

	15 @class RTCVideoCapturer;

	16

	17 RTC_EXPORT

	18

	19 @protocol RTCVideoCapturerDelegate
	tkchin_webrtc 2017/04/06 18:01:52 @protocol RTCVideoCapturerDelegate <NSObject> @protocol RTCVideoCapturerDelegate <NSObject> magjed_webrtc 2017/04/10 12:12:50 Done. Show quoted text On 2017/04/06 18:01:52, tkchin_webrtc wrote: > @protocol RTCVideoCapturerDelegate <NSObject> Done.
	20 - (void)capturer:(RTCVideoCapturer )capturer didCaptureVideoFrame:(RTCVideoFram e )frame;

	21 @end

	22

	23 @interface RTCVideoCapturer : NSObject
	tkchin_webrtc 2017/04/06 18:01:52 The RTC_EXPORT should appear before this one, not The RTC_EXPORT should appear before this one, not the protocol I think. magjed_webrtc 2017/04/10 12:12:50 I think I need it for both actually. Show quoted text On 2017/04/06 18:01:52, tkchin_webrtc wrote: > The RTC_EXPORT should appear before this one, not the protocol I think. I think I need it for both actually.
	24 - (instancetype)initWithDelegate:(id<RTCVideoCapturerDelegate>)delegate;

	25 @property(nonatomic, readonly, weak) id<RTCVideoCapturerDelegate> delegate;
	tkchin_webrtc 2017/04/06 18:01:52 style: properties before methods add blank lines style: properties before methods add blank lines to make it more readable magjed_webrtc 2017/04/10 12:12:50 Done. Show quoted text On 2017/04/06 18:01:52, tkchin_webrtc wrote: > style: properties before methods > > add blank lines to make it more readable Done.
	26 @end

	27

	28 NS_ASSUME_NONNULL_END

OLD	NEW