Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2744813002: Start documenting the threading model (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Start documenting the threading model BUG=

Patch Set 1 #

Patch Set 2 : Check if Decoded is called on a different thread on android #

Patch Set 3 : Check video_engine_tests on android #

Patch Set 4 : Hack the timed message to see if frames get delivered #

Patch Set 5 : Disable check #

Patch Set 6 : Add Poll hack #

Patch Set 7 : Enable thread check again #

Patch Set 8 : See if nanosleep on android affects the busy Voice and Pacer threads #

Patch Set 9 : request keyframes after 3sec with a dcheck #

Patch Set 10 : Avoid busy looping in PacedSender while paused #

Patch Set 11 : Add dependency #

Patch Set 12 : Fix pause test + dbg processthread #

Patch Set 13 : Voice2 #

Patch Set 14 : ProcessThread crazy #

Patch Set 15 : Further processthread debug #

Patch Set 16 : More process thread #

Patch Set 17 : Back out VideoReceiveStream change #

Patch Set 18 : Modify EndToEndConnectionTimeWithTurnTurnPair to yield occasionally to slow down time #

Patch Set 19 : Always sleep on Android #

Patch Set 20 : log debugging... #

Patch Set 21 : Use atomic in FrameBuffer and don't Reset() the event #

Patch Set 22 : Revert lots of dbg changes #

Patch Set 23 : Add more thread checks to the generic decoder #

Patch Set 24 : Comment dcheck in dtor #

Patch Set 25 : Remove poll in MediaCodecVideoDecoder in favor of the one in VideoReceiveStream #

Patch Set 26 : Cleanup the android mediacodec code #

Patch Set 27 : Convert thread checks in Android code to DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -183 lines) Patch
M webrtc/modules/pacing/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 2 3 4 5 6 7 8 9 4 chunks +21 lines, -4 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 8 chunks +27 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +29 lines, -22 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 8 chunks +88 lines, -37 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 chunks +118 lines, -83 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 5 chunks +40 lines, -13 lines 0 comments Download
M webrtc/video_decoder.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 160 (115 generated)
tommi
Remove printfs
3 years, 9 months ago (2017-03-10 11:39:31 UTC) #5
tommi
Check if Decoded is called on a different thread on android
3 years, 9 months ago (2017-03-10 11:59:17 UTC) #10
tommi
Don't raise the thread priority of the decoder thread, on Android
3 years, 9 months ago (2017-03-11 11:24:41 UTC) #14
tommi
Format
3 years, 9 months ago (2017-03-11 11:28:11 UTC) #15
tommi
rebase
3 years, 9 months ago (2017-03-11 15:09:39 UTC) #20
tommi
Check video_engine_tests on android
3 years, 9 months ago (2017-03-11 16:49:20 UTC) #21
tommi
More video_engine_test probing
3 years, 9 months ago (2017-03-11 17:20:59 UTC) #22
tommi
Add more debugging
3 years, 9 months ago (2017-03-11 18:35:42 UTC) #27
tommi
semicolon
3 years, 9 months ago (2017-03-11 18:40:26 UTC) #28
tommi
Attempt to deliver frames on callback thread
3 years, 9 months ago (2017-03-11 19:15:12 UTC) #31
tommi
std::queue->std::vector for simplicity
3 years, 9 months ago (2017-03-11 19:26:54 UTC) #32
tommi
Debug...
3 years, 9 months ago (2017-03-11 20:32:28 UTC) #41
tommi
Hack the timed message to see if frames get delivered
3 years, 9 months ago (2017-03-11 21:13:49 UTC) #42
tommi
Disable check
3 years, 9 months ago (2017-03-11 21:38:44 UTC) #43
tommi
Add Poll hack
3 years, 9 months ago (2017-03-12 11:48:17 UTC) #51
tommi
Add Poll hack
3 years, 9 months ago (2017-03-12 11:54:52 UTC) #56
tommi
Enable thread check again
3 years, 9 months ago (2017-03-12 12:33:04 UTC) #62
tommi
See if nanosleep on android affects the busy Voice and Pacer threads
3 years, 9 months ago (2017-03-12 12:50:07 UTC) #67
tommi
Check for busy decoder loop
3 years, 9 months ago (2017-03-12 13:56:30 UTC) #72
tommi
printf instead of check, never request keyframe on timeout
3 years, 9 months ago (2017-03-12 15:01:36 UTC) #77
tommi
request keyframes after 3sec with a dcheck
3 years, 9 months ago (2017-03-12 15:18:12 UTC) #82
tommi
Avoid busy looping in PacedSender while paused
3 years, 9 months ago (2017-03-12 16:16:05 UTC) #89
tommi
Add dependency
3 years, 9 months ago (2017-03-12 19:30:19 UTC) #94
tommi
Fix pause test + dbg processthread
3 years, 9 months ago (2017-03-12 20:06:44 UTC) #100
tommi
Voice2
3 years, 9 months ago (2017-03-12 20:59:48 UTC) #101
tommi
ProcessThread crazy
3 years, 9 months ago (2017-03-12 21:07:09 UTC) #102
tommi
Further processthread debug
3 years, 9 months ago (2017-03-12 21:41:22 UTC) #103
tommi
More process thread
3 years, 9 months ago (2017-03-12 21:49:52 UTC) #104
tommi
Back out VideoReceiveStream change
3 years, 9 months ago (2017-03-12 22:07:42 UTC) #105
tommi
Modify EndToEndConnectionTimeWithTurnTurnPair to yield occasionally to slow down time
3 years, 9 months ago (2017-03-12 22:50:40 UTC) #106
tommi
Always sleep on Android
3 years, 9 months ago (2017-03-12 23:08:34 UTC) #107
tommi
log debugging...
3 years, 9 months ago (2017-03-12 23:34:06 UTC) #112
tommi
argh
3 years, 9 months ago (2017-03-12 23:50:52 UTC) #113
tommi
Use atomic in FrameBuffer and don't Reset() the event
3 years, 9 months ago (2017-03-13 00:19:45 UTC) #114
tommi
Rebase
3 years, 9 months ago (2017-03-13 00:32:52 UTC) #116
tommi
Revert lots of dbg changes
3 years, 9 months ago (2017-03-13 00:46:21 UTC) #121
tommi
Rebase + more FrameBuffer
3 years, 9 months ago (2017-03-13 08:47:23 UTC) #126
tommi
Don't grab lock before calling stream_resetter_
3 years, 9 months ago (2017-03-13 09:03:57 UTC) #131
tommi
Rebase
3 years, 9 months ago (2017-03-13 15:44:29 UTC) #137
tommi
Add more thread checks to the generic decoder
3 years, 9 months ago (2017-03-13 17:44:55 UTC) #139
tommi
Comment dcheck in dtor
3 years, 9 months ago (2017-03-13 18:14:38 UTC) #144
tommi
Remove sleep
3 years, 9 months ago (2017-03-13 18:22:57 UTC) #150
tommi
Remove poll in MediaCodecVideoDecoder in favor of the one in VideoReceiveStream
3 years, 9 months ago (2017-03-13 20:30:36 UTC) #151
tommi
Cleanup the android mediacodec code
3 years, 9 months ago (2017-03-13 20:44:06 UTC) #152
tommi
3 years, 9 months ago (2017-03-13 20:58:42 UTC) #156
Convert thread checks in Android code to DCHECKs

Powered by Google App Engine
This is Rietveld 408576698