webrtc/video/video_receive_stream.cc - Issue 2744013002: Updates to VCMDecodedFrameCallback, VideoReceiver and a few related classes/tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_receive_stream.cc

Issue 2744013002: Updates to VCMDecodedFrameCallback, VideoReceiver and a few related classes/tests. (Closed)

Patch Set: Format + assert->DCHECK and require callback in decode Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_receive_stream.cc

diff --git a/webrtc/video/video_receive_stream.cc b/webrtc/video/video_receive_stream.cc

index eb2404c174ed749baef44638c831249a0499a415..47e8c1efad5dda04eee9e4f00f47a88334a3bbe6 100644

--- a/webrtc/video/video_receive_stream.cc

+++ b/webrtc/video/video_receive_stream.cc

@@ -481,8 +481,10 @@ bool VideoReceiveStream::Decode() {

video_coding::FrameBuffer::ReturnReason res =

frame_buffer_->NextFrame(kMaxWaitForFrameMs, &frame);

- if (res == video_coding::FrameBuffer::ReturnReason::kStopped)

+ if (res == video_coding::FrameBuffer::ReturnReason::kStopped) {

+ video_receiver_.DecodingStopped();

return false;

+ }

if (frame) {

if (video_receiver_.Decode(frame.get()) == VCM_OK)