Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: webrtc/modules/congestion_controller/transport_feedback_adapter.h

Issue 2743553003: Revert of Move delay_based_bwe_ into CongestionController (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 11 #ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
12 #define WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 12 #define WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
13 13
14 #include <memory>
14 #include <vector> 15 #include <vector>
15 16
16 #include "webrtc/base/criticalsection.h" 17 #include "webrtc/base/criticalsection.h"
17 #include "webrtc/base/thread_annotations.h" 18 #include "webrtc/base/thread_annotations.h"
18 #include "webrtc/base/thread_checker.h" 19 #include "webrtc/base/thread_checker.h"
20 #include "webrtc/modules/congestion_controller/delay_based_bwe.h"
21 #include "webrtc/modules/include/module_common_types.h"
19 #include "webrtc/modules/remote_bitrate_estimator/include/send_time_history.h" 22 #include "webrtc/modules/remote_bitrate_estimator/include/send_time_history.h"
20 #include "webrtc/system_wrappers/include/clock.h"
21 23
22 namespace webrtc { 24 namespace webrtc {
23 25
24 namespace rtcp { 26 class BitrateController;
25 class TransportFeedback; 27 class RtcEventLog;
26 } // namespace rtcp 28 class ProcessThread;
27 29
28 class TransportFeedbackAdapter { 30 class TransportFeedbackAdapter : public TransportFeedbackObserver,
31 public CallStatsObserver {
29 public: 32 public:
30 explicit TransportFeedbackAdapter(Clock* clock); 33 TransportFeedbackAdapter(RtcEventLog* event_log,
34 Clock* clock,
35 BitrateController* bitrate_controller);
31 virtual ~TransportFeedbackAdapter(); 36 virtual ~TransportFeedbackAdapter();
32 37
38 void InitBwe();
39 // Implements TransportFeedbackObserver.
33 void AddPacket(uint16_t sequence_number, 40 void AddPacket(uint16_t sequence_number,
34 size_t length, 41 size_t length,
35 const PacedPacketInfo& pacing_info); 42 const PacedPacketInfo& pacing_info) override;
36 void OnSentPacket(uint16_t sequence_number, int64_t send_time_ms); 43 void OnSentPacket(uint16_t sequence_number, int64_t send_time_ms);
37 44
38 // TODO(holmer): This method should return DelayBasedBwe::Result so that we 45 // TODO(holmer): This method should return DelayBasedBwe::Result so that we
39 // can get rid of the dependency on BitrateController. Requires changes 46 // can get rid of the dependency on BitrateController. Requires changes
40 // to the CongestionController interface. 47 // to the CongestionController interface.
41 void OnTransportFeedback(const rtcp::TransportFeedback& feedback); 48 void OnTransportFeedback(const rtcp::TransportFeedback& feedback) override;
42 std::vector<PacketFeedback> GetTransportFeedbackVector() const; 49 std::vector<PacketFeedback> GetTransportFeedbackVector() const override;
43 50
51 // Implements CallStatsObserver.
52 void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) override;
53
54 void SetStartBitrate(int start_bitrate_bps);
55 void SetMinBitrate(int min_bitrate_bps);
44 void SetTransportOverhead(int transport_overhead_bytes_per_packet); 56 void SetTransportOverhead(int transport_overhead_bytes_per_packet);
45 57
58 int64_t GetProbingIntervalMs() const;
59
46 void ClearSendTimeHistory(); 60 void ClearSendTimeHistory();
47 61
48 private: 62 private:
49 std::vector<PacketFeedback> GetPacketFeedbackVector( 63 std::vector<PacketFeedback> GetPacketFeedbackVector(
50 const rtcp::TransportFeedback& feedback); 64 const rtcp::TransportFeedback& feedback);
51 65
52 const bool send_side_bwe_with_overhead_; 66 const bool send_side_bwe_with_overhead_;
53 rtc::CriticalSection lock_; 67 rtc::CriticalSection lock_;
68 rtc::CriticalSection bwe_lock_;
54 int transport_overhead_bytes_per_packet_ GUARDED_BY(&lock_); 69 int transport_overhead_bytes_per_packet_ GUARDED_BY(&lock_);
55 SendTimeHistory send_time_history_ GUARDED_BY(&lock_); 70 SendTimeHistory send_time_history_ GUARDED_BY(&lock_);
56 const Clock* const clock_; 71 std::unique_ptr<DelayBasedBwe> delay_based_bwe_ GUARDED_BY(&bwe_lock_);
72 RtcEventLog* const event_log_;
73 Clock* const clock_;
57 int64_t current_offset_ms_; 74 int64_t current_offset_ms_;
58 int64_t last_timestamp_us_; 75 int64_t last_timestamp_us_;
76 BitrateController* const bitrate_controller_;
59 std::vector<PacketFeedback> last_packet_feedback_vector_; 77 std::vector<PacketFeedback> last_packet_feedback_vector_;
60 }; 78 };
61 79
62 } // namespace webrtc 80 } // namespace webrtc
63 81
64 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 82 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698