Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: webrtc/api/ortc/mediadescription.h

Issue 2743003004: Add skeleton webrtc::SessionDescription and webrtc::MediaDescription classes. (Closed)
Patch Set: CR comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/ortc/mediadescription.h
diff --git a/webrtc/api/ortc/mediadescription.h b/webrtc/api/ortc/mediadescription.h
new file mode 100644
index 0000000000000000000000000000000000000000..164f0785e5938168bb4a0bead877afb8c9b3ed24
--- /dev/null
+++ b/webrtc/api/ortc/mediadescription.h
@@ -0,0 +1,41 @@
+/*
+ * Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_API_ORTC_MEDIADESCRIPTION_H_
+#define WEBRTC_API_ORTC_MEDIADESCRIPTION_H_
+
+#include <string>
+#include <utility>
+
+#include "webrtc/base/optional.h"
+
+namespace webrtc {
+
+// A structured representation of a media description within an SDP session
+// description.
+class MediaDescription {
+ public:
+ explicit MediaDescription(std::string mid) : mid_(std::move(mid)) {}
+
+ ~MediaDescription() {}
+
+ rtc::Optional<std::string> mid() const { return mid_; }
+ void set_mid(std::string mid) { mid_.emplace(mid); }
Taylor Brandstetter 2017/03/11 01:37:07 std::move(mid) here too.
+
+ private:
+ // The mid(media stream identification) is used for identifying media streams
+ // within a session description.
+ // https://tools.ietf.org/html/rfc5888#section-6
Taylor Brandstetter 2017/03/11 01:37:07 Can you move this comment to above the "mid()" met
+ rtc::Optional<std::string> mid_;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_API_ORTC_MEDIADESCRIPTION_H_

Powered by Google App Engine
This is Rietveld 408576698