Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: webrtc/api/ortc/mediadescription.h

Issue 2743003004: Add skeleton webrtc::SessionDescription and webrtc::MediaDescription classes. (Closed)
Patch Set: CR comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #ifndef WEBRTC_API_ORTC_MEDIADESCRIPTION_H_
12 #define WEBRTC_API_ORTC_MEDIADESCRIPTION_H_
13
14 #include <string>
15 #include <utility>
16
17 #include "webrtc/base/optional.h"
18
19 namespace webrtc {
20
21 // A structured representation of a media description within an SDP session
22 // description.
23 class MediaDescription {
24 public:
25 explicit MediaDescription(std::string mid) : mid_(std::move(mid)) {}
26
27 ~MediaDescription() {}
28
29 rtc::Optional<std::string> mid() const { return mid_; }
30 void set_mid(std::string mid) { mid_.emplace(mid); }
Taylor Brandstetter 2017/03/11 01:37:07 std::move(mid) here too.
31
32 private:
33 // The mid(media stream identification) is used for identifying media streams
34 // within a session description.
35 // https://tools.ietf.org/html/rfc5888#section-6
Taylor Brandstetter 2017/03/11 01:37:07 Can you move this comment to above the "mid()" met
36 rtc::Optional<std::string> mid_;
37 };
38
39 } // namespace webrtc
40
41 #endif // WEBRTC_API_ORTC_MEDIADESCRIPTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698