Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: webrtc/api/ortc/sessiondescription.h

Issue 2743003004: Add skeleton webrtc::SessionDescription and webrtc::MediaDescription classes. (Closed)
Patch Set: Take over Zach's work. Fix the build and address some comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #ifndef WEBRTC_API_ORTC_SESSIONDESCRIPTION_H_
12 #define WEBRTC_API_ORTC_SESSIONDESCRIPTION_H_
13
14 #include <string>
15
16 namespace webrtc {
17
18 // A structured representation of an SDP message.
19 class SessionDescription {
20 public:
21 SessionDescription(std::string session_id, std::string session_version)
22 : session_id_(session_id), session_version_(session_version) {}
Taylor Brandstetter 2017/03/11 00:24:29 Should be session_id_(std::move(session_id)) to en
Zhi Huang 2017/03/11 01:20:39 Done.
23
24 std::string session_id() const { return session_id_; }
Taylor Brandstetter 2017/03/11 00:24:29 Would be nice to add comments for where these thin
Taylor Brandstetter 2017/03/11 00:24:29 These could return const refs.
Zhi Huang 2017/03/11 01:20:39 Done.
Zhi Huang 2017/03/11 01:20:39 Done.
25 void set_session_id(std::string session_id) { session_id_ = session_id; }
26
27 std::string session_version() const { return session_version_; }
28 void set_session_version(std::string session_version) {
29 session_version_ = session_version;
30 }
31
32 private:
33 std::string session_id_;
34 std::string session_version_;
35 };
36
37 } // namespace webrtc
38
39 #endif // WEBRTC_API_ORTC_SESSIONDESCRIPTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698