Parse the connection data in SDP (c= line).

webrtc/pc/webrtcsdp_unittest.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 850 matching lines @@
 // WebRtcSdpTest
 
 class WebRtcSdpTest : public testing::Test {
  public:
   WebRtcSdpTest()
      : jdesc_(kDummyString) {
 #ifdef WEBRTC_ANDROID
     webrtc::InitializeAndroidObjects();
 #endif
     // AudioContentDescription
     audio_desc_ = CreateAudioContentDescription();

[Taylor Brandstetter, 2017/03/10 22:41:18]

To be consistent with how most things in this file are tested, you could set the
connection_address for the audio/video descriptions here...

[Zhi Huang, 2017/03/15 04:04:59]

Done.

     StreamParams audio_stream;
     audio_stream.id = kAudioTrackId1;
     audio_stream.cname = kStream1Cname;
     audio_stream.sync_label = kStreamLabel1;
     audio_stream.ssrcs.push_back(kAudioTrack1Ssrc);
     audio_desc_->AddStream(audio_stream);
     desc_.AddContent(kAudioContentName, NS_JINGLE_RTP, audio_desc_);
 
     // VideoContentDescription
     video_desc_ = CreateVideoContentDescription();
@@ skipping 262 matching lines @@
         1, "AES_CM_128_HMAC_SHA1_80",
         "inline:d0RmdmcmVCspeEc3QGZiNWpVLFJhQX1cfHAwJSoj|2^20|1:32", ""));
     video->set_protocol(cricket::kMediaProtocolSavpf);
     video->AddCodec(
         VideoCodec(120, JsepSessionDescription::kDefaultVideoCodecName));
     return video;
   }
 
   template <class MCD>
   void CompareMediaContentDescription(const MCD* cd1,
                                       const MCD* cd2) {

[Taylor Brandstetter, 2017/03/10 22:41:18]

... and add code to compare them in this method. Though you would still need
additional tests for "c=" at the session level, and for IPv6.

[Zhi Huang, 2017/03/15 04:04:59]

Done.

     // type
     EXPECT_EQ(cd1->type(), cd1->type());
 
     // content direction
     EXPECT_EQ(cd1->direction(), cd2->direction());
 
     // rtcp_mux
     EXPECT_EQ(cd1->rtcp_mux(), cd2->rtcp_mux());
 
     // rtcp_reduced_size
@@ skipping 2332 matching lines @@
       "s=-\r\n"
       "t=0 0\r\n"
       "m=audio 9 RTP/SAVPF 111\r\n"
       "c=IN IP4 0.0.0.0\r\n"
       "a=rtpmap:111 opus/48000/2\r\n"
       "a=msid: track_id\r\n";
 
   JsepSessionDescription jdesc_output(kDummyString);
   EXPECT_FALSE(SdpDeserialize(kSdpWithMissingStreamId, &jdesc_output));
 }
+
+// Tests that the connection data on both the session level and media level can
+// be sucessfully parsed.
+TEST_F(WebRtcSdpTest, ParseConnectionData) {
+  JsepSessionDescription jsep_desc(kDummyString);
+
+  // IPv4 addresses.
+  std::string sdp = kSdpFullString;
+  InjectAfter("s=-\r\n", "c=IN IP4 192.168.0.1\r\n", &sdp);
+  EXPECT_TRUE(SdpDeserialize(sdp, &jsep_desc));
+  ASSERT_TRUE(jsep_desc.description()->session_connection_addr());
+  // The port is expected to be the default value 0.
+  EXPECT_EQ("192.168.0.1:0",
+            jsep_desc.description()->session_connection_addr()->ToString());
+  const auto& content1 = jsep_desc.description()->contents()[0];
+  EXPECT_EQ("74.125.127.126:0",
+            static_cast<cricket::MediaContentDescription*>(content1.description)
+                ->media_connection_addr()
+                ->ToString());
+  const auto& content2 = jsep_desc.description()->contents()[1];
+  EXPECT_EQ("74.125.224.39:0",
+            static_cast<cricket::MediaContentDescription*>(content2.description)
+                ->media_connection_addr()
+                ->ToString());
+
+  // IPv6 addresses/
+  sdp = kSdpFullString;
+  InjectAfter("s=-\r\n", "c=IN IP6 2001:0db8:85a3:0000:0000:8a2e:0370:7334\r\n",
+              &sdp);
+  EXPECT_TRUE(SdpDeserialize(sdp, &jsep_desc));
+  Replace("c=IN IP4 74.125.127.126\r\n",
+          "c=IN IP6 2001:0db8:85a3:0000:0000:8a2e:0370:7335\r\n", &sdp);
+  Replace("c=IN IP4 74.125.224.39\r\n",
+          "c=IN IP6 2001:0db8:85a3:0000:0000:8a2e:0370:7336\r\n", &sdp);
+  EXPECT_TRUE(SdpDeserialize(sdp, &jsep_desc));
+  ASSERT_TRUE(jsep_desc.description()->session_connection_addr());
+  EXPECT_EQ("[2001:db8:85a3::8a2e:370:7334]:0",
+            jsep_desc.description()->session_connection_addr()->ToString());
+  const auto& content3 = jsep_desc.description()->contents()[0];
+  EXPECT_EQ("[2001:db8:85a3::8a2e:370:7335]:0",
+            static_cast<cricket::MediaContentDescription*>(content3.description)
+                ->media_connection_addr()
+                ->ToString());
+  const auto& content4 = jsep_desc.description()->contents()[1];
+  EXPECT_EQ("[2001:db8:85a3::8a2e:370:7336]:0",
+            static_cast<cricket::MediaContentDescription*>(content4.description)
+                ->media_connection_addr()
+                ->ToString());
+}
+
+// Test that the invalid connection data cannot be parsed.

[Taylor Brandstetter, 2017/03/10 22:41:18]

I'd use the term "unsupported" rather than "invalid", since multicast addresses
are valid from an SDP perspective.

+TEST_F(WebRtcSdpTest, ParseInvalidConnectionData) {
+  JsepSessionDescription jsep_desc(kDummyString);
+  std::string sdp = kSdpFullString;
+  EXPECT_TRUE(SdpDeserialize(sdp, &jsep_desc));
+
+  // Invalid session level IPv4 address.
+  InjectAfter("s=-\r\n", "c=IN IP4 192.168.0.1/127\r\n", &sdp);
+  EXPECT_FALSE(SdpDeserialize(sdp, &jsep_desc));
+
+  // Invalid media level IPv4 address.
+  sdp = kSdpFullString;
+  Replace("c=IN IP4 74.125.224.39\r\n", "c=IN IP4 74.125.224.39/127\r\n", &sdp);
+  EXPECT_FALSE(SdpDeserialize(sdp, &jsep_desc));
+
+  // Invalid session level IPv6 address.
+  sdp = kSdpFullString;
+  EXPECT_TRUE(SdpDeserialize(sdp, &jsep_desc));
+  InjectAfter("s=-\r\n",
+              "c=IN IP6 2001:0db8:85a3:0000:0000:8a2e:0370:7334/3\r\n", &sdp);
+  EXPECT_FALSE(SdpDeserialize(sdp, &jsep_desc));
+
+  // Invalid media level IPv6 address.
+  sdp = kSdpFullString;
+  Replace("c=IN IP4 74.125.224.39\r\n",
+          "c=IN IP6 2001:0db8:85a3:0000:0000:8a2e:0370:7334/3\r\n", &sdp);
+  EXPECT_FALSE(SdpDeserialize(sdp, &jsep_desc));
+}