webrtc/modules/rtp_rtcp/source/rtp_utility.cc - Issue 2742383004: Delete support for receiving RTCP RPSI and SLI messages.

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2742383004: Delete support for receiving RTCP RPSI and SLI messages. (Closed)

Patch Set: Add back OnReceivedSLI and OnReceivedRPSI, to not break downstream sub classes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h ('K') | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_config.h ('k') | webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101	101

102 /* 205 RFC 5104	102 /* 205 RFC 5104

103 * FMT 1 NACK supported	103 * FMT 1 NACK supported

104 * FMT 2 reserved	104 * FMT 2 reserved

105 * FMT 3 TMMBR supported	105 * FMT 3 TMMBR supported

106 * FMT 4 TMMBN supported	106 * FMT 4 TMMBN supported

107 */	107 */

108	108

109 /* 206 RFC 5104	109 /* 206 RFC 5104

110 * FMT 1: Picture Loss Indication (PLI) supported	110 * FMT 1: Picture Loss Indication (PLI) supported

111 * FMT 2: Slice Lost Indication (SLI)	111 * FMT 2: Slice Lost Indication (SLI)
	danilchap 2017/03/21 14:53:24 either add 'not implemented' this line too. or do either add 'not implemented' this line too. or do not add 'not implemented' next line (preferred since other 'non implemented' messages do not have that note) nisse-webrtc 2017/03/21 15:12:55 Delete the note. Show quoted text On 2017/03/21 14:53:24, danilchap wrote: > either add 'not implemented' this line too. or do not add 'not implemented' next > line (preferred since other 'non implemented' messages do not have that note) Delete the note.
112 * FMT 3: Reference Picture Selection Indication (RPSI)	112 * FMT 3: Reference Picture Selection Indication (RPSI) not implemented

113 * FMT 4: Full Intra Request (FIR) Command supported	113 * FMT 4: Full Intra Request (FIR) Command supported

114 * FMT 5: Temporal-Spatial Trade-off Request (TSTR)	114 * FMT 5: Temporal-Spatial Trade-off Request (TSTR)

115 * FMT 6: Temporal-Spatial Trade-off Notification (TSTN)	115 * FMT 6: Temporal-Spatial Trade-off Notification (TSTN)

116 * FMT 7: Video Back Channel Message (VBCM)	116 * FMT 7: Video Back Channel Message (VBCM)

117 * FMT 15: Application layer FB message	117 * FMT 15: Application layer FB message

118 */	118 */

119	119

120 const ptrdiff_t length = _ptrRTPDataEnd - _ptrRTPDataBegin;	120 const ptrdiff_t length = _ptrRTPDataEnd - _ptrRTPDataBegin;

121 if (length < kRtcpMinHeaderLength) {	121 if (length < kRtcpMinHeaderLength) {

122 return false;	122 return false;

(...skipping 329 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
452 return;	452 return;

453 }	453 }

454 }	454 }

455 }	455 }

456 ptr += (len + 1);	456 ptr += (len + 1);

457 }	457 }

458 }	458 }

459	459

460 } // namespace RtpUtility	460 } // namespace RtpUtility

461 } // namespace webrtc	461 } // namespace webrtc

OLD	NEW