Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: webrtc/common_types.h

Issue 2742383004: Delete support for receiving RTCP RPSI and SLI messages. (Closed)
Patch Set: Add back OnReceivedSLI and OnReceivedRPSI, to not break downstream sub classes. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 // packet losses, but packets within a frame subsequent 455 // packet losses, but packets within a frame subsequent
456 // to a loss can't be decoded. 456 // to a loss can't be decoded.
457 kResilientFrames // Same as kResilientStream but with added resilience 457 kResilientFrames // Same as kResilientStream but with added resilience
458 // within a frame. 458 // within a frame.
459 }; 459 };
460 460
461 class TemporalLayersFactory; 461 class TemporalLayersFactory;
462 // VP8 specific 462 // VP8 specific
463 struct VideoCodecVP8 { 463 struct VideoCodecVP8 {
464 // TODO(nisse): Unused, delete? 464 // TODO(nisse): Unused, delete?
465 bool pictureLossIndicationOn; 465 bool pictureLossIndicationOn;
danilchap 2017/03/21 14:53:24 anything hold you from deleting this field too?
nisse-webrtc 2017/03/21 15:12:55 There are some tests for it, and I haven't researc
danilchap 2017/03/21 15:19:42 Ok
466 // TODO(nisse): Delete, as soon as downstream applications are updated.
467 bool feedbackModeOn;
468 VideoCodecComplexity complexity; 466 VideoCodecComplexity complexity;
469 VP8ResilienceMode resilience; 467 VP8ResilienceMode resilience;
470 unsigned char numberOfTemporalLayers; 468 unsigned char numberOfTemporalLayers;
471 bool denoisingOn; 469 bool denoisingOn;
472 bool errorConcealmentOn; 470 bool errorConcealmentOn;
473 bool automaticResizeOn; 471 bool automaticResizeOn;
474 bool frameDroppingOn; 472 bool frameDroppingOn;
475 int keyFrameInterval; 473 int keyFrameInterval;
476 TemporalLayersFactory* tl_factory; 474 TemporalLayersFactory* tl_factory;
477 }; 475 };
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 enum class RtcpMode { kOff, kCompound, kReducedSize }; 836 enum class RtcpMode { kOff, kCompound, kReducedSize };
839 837
840 enum NetworkState { 838 enum NetworkState {
841 kNetworkUp, 839 kNetworkUp,
842 kNetworkDown, 840 kNetworkDown,
843 }; 841 };
844 842
845 } // namespace webrtc 843 } // namespace webrtc
846 844
847 #endif // WEBRTC_COMMON_TYPES_H_ 845 #endif // WEBRTC_COMMON_TYPES_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log2text.cc » ('j') | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698