IdlingResource for destroy() VideoFileRenderer

webrtc/examples/androidtests/video_quality_loopback_test.py

 #!/usr/bin/env python
 # Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 """
@@ skipping 18 matching lines @@
 
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 SRC_DIR = os.path.normpath(os.path.join(SCRIPT_DIR, os.pardir, os.pardir,
                                         os.pardir))
 
 
 def _RunCommand(argv, cwd=SRC_DIR, **kwargs):
   logging.info('Running %r', argv)
   subprocess.check_call(argv, cwd=cwd, **kwargs)
 
+def _Popen(argv, cwd=SRC_DIR):
+  logging.info('Running %r', argv)
+  return subprocess.Popen(argv, cwd=cwd)
 
 def _ParseArgs():
   parser = argparse.ArgumentParser(description='Start loopback video analysis.')
   parser.add_argument('build_dir_android',
       help='The path to the build directory for Android.')
   parser.add_argument('--build_dir_x86',
       help='The path to the build directory for building locally.')
   parser.add_argument('--temp_dir',
       help='A temporary directory to put the output.')
 
@@ skipping 20 matching lines @@
     _RunCommand(['gn', 'gen', build_dir_x86])
     _RunCommand(['ninja', '-C', build_dir_x86, 'frame_analyzer'])
 
   tools_dir = os.path.join(SRC_DIR, 'tools-webrtc')
   toolchain_dir = os.path.join(tools_dir, 'video_quality_toolchain')
 
   # Download ffmpeg and zxing.
   download_script = os.path.join(tools_dir, 'download_tools.py')
   _RunCommand([sys.executable, download_script, toolchain_dir])
 
+  # Start AppRTC Server
+  dev_appserver = os.path.join(SRC_DIR, 'out', 'apprtc', 'google_appengine',

[kjellander_webrtc, 2017/03/17 12:02:16]

Add try+finally around the processes being launched so you ensure you terminate
them no matter what happens.

I guess you have two options here, defining all three variables (apprtc_process,
collider_process, reverseforwarder_process) to none outside a single try+finally
clause, or nest three different ones inside each other. I think the former is
less cluttered.

I think you also should implement a SIGINT handler to protect against zombie
processes staying around if ctrl+c is pressed during execution (or if the test
is interrupted when running on the bot).
See http://stackoverflow.com/questions/1112343/how-do-i-capture-sigint-in-python
for example.

[mandermo, 2017/03/17 13:39:42]

Fixed with try+finally. Leave SIGINT for later.

+      'dev_appserver.py')
+  appengine_dir = os.path.join(SRC_DIR, 'out', 'apprtc', 'out', 'app_engine')
+  apprtc_process = _Popen(['python', dev_appserver, appengine_dir,
+    '--port=9999', '--admin_port=9998', '--skip_sdk_update_check',
+    '--clear_datastore=yes'])
+
+  # Start Collider
+  collider_path = os.path.join(SRC_DIR, 'out', 'go-workspace', 'bin',
+      'collidermain')
+  collider_process = _Popen([collider_path, '-tls=false', '-port=8089',
+    '-room-server=http://localhost:9999'])
+
+  # Start adb reverse forwarder
+  reverseforwarder_path = os.path.join(
+      SRC_DIR, 'build', 'android', 'adb_reverse_forwarder.py')
+  reverseforwarder_process = _Popen(
+      [reverseforwarder_path, '9999', '9999', '8089', '8089'])
+
   # Run the Espresso code.
   test_script = os.path.join(build_dir_android,
       'bin', 'run_AppRTCMobileTestStubbedVideoIO')
   _RunCommand([sys.executable, test_script])
 
+  apprtc_process.terminate()
+  collider_process.terminate()
+  reverseforwarder_process.terminate()
+
   # Pull the output video.
   test_video = os.path.join(temp_dir, 'test_video.y4m')
   _RunCommand(['adb', 'pull', '/sdcard/output.y4m', test_video])
 
   test_video_yuv = os.path.join(temp_dir, 'test_video.yuv')
 
   ffmpeg_path = os.path.join(toolchain_dir, 'linux', 'ffmpeg')
 
   def convert_video(input_video, output_video):
     _RunCommand([ffmpeg_path, '-y', '-i', input_video, output_video])
@@ skipping 30 matching lines @@
       '--stats_file_ref', stats_file_ref,
       '--stats_file_test', stats_file_test, '--frame_analyzer', frame_analyzer,
       '--ffmpeg_path', ffmpeg_path, '--zxing_path', zxing_path])
 
   shutil.rmtree(temp_dir)
 
 
 if __name__ == '__main__':
   sys.exit(main())