webrtc/video/rtp_stream_receiver.cc - Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/rtp_stream_receiver.cc

Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/rtp_stream_receiver.cc

diff --git a/webrtc/video/rtp_stream_receiver.cc b/webrtc/video/rtp_stream_receiver.cc

index b8ef10d549b802de1b963e8e50a3ce4b37bc230b..8ee8241cca1aaa4c2e8bc0e2587c1de30a919cc2 100644

--- a/webrtc/video/rtp_stream_receiver.cc

+++ b/webrtc/video/rtp_stream_receiver.cc

@@ -74,7 +74,6 @@ std::unique_ptr<RtpRtcp> CreateRtpRtcpModule(

std::unique_ptr<RtpRtcp> rtp_rtcp(RtpRtcp::CreateRtpRtcp(configuration));

rtp_rtcp->SetSendingStatus(false);

- rtp_rtcp->SetSendingMediaStatus(false);

rtp_rtcp->SetRTCPStatus(RtcpMode::kCompound);

return rtp_rtcp;