webrtc/modules/rtp_rtcp/source/rtcp_sender.cc - Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

index 986d51acd40702c9c25ced0786ca38b60c44c375..caef2cfd0faa2c4f6d737750a0921fdeec1a0174 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

@@ -303,6 +303,11 @@ void RTCPSender::SetLastRtpTime(uint32_t rtp_timestamp,

}

+uint32_t RTCPSender::SSRC() const {

+ rtc::CritScope lock(&critical_section_rtcp_sender_);

+ return ssrc_;

void RTCPSender::SetSSRC(uint32_t ssrc) {

rtc::CritScope lock(&critical_section_rtcp_sender_);