Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/rtp_stream_receiver.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2103 matching lines...) Expand 10 before | Expand all | Expand 10 after
2114 ASSERT_EQ(1u, receive_configs->size()); 2114 ASSERT_EQ(1u, receive_configs->size());
2115 RtpRtcp::Configuration config; 2115 RtpRtcp::Configuration config;
2116 config.receiver_only = true; 2116 config.receiver_only = true;
2117 config.clock = clock_; 2117 config.clock = clock_;
2118 config.outgoing_transport = receive_transport_; 2118 config.outgoing_transport = receive_transport_;
2119 config.retransmission_rate_limiter = &retransmission_rate_limiter_; 2119 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2120 rtp_rtcp_.reset(RtpRtcp::CreateRtpRtcp(config)); 2120 rtp_rtcp_.reset(RtpRtcp::CreateRtpRtcp(config));
2121 rtp_rtcp_->SetRemoteSSRC((*receive_configs)[0].rtp.remote_ssrc); 2121 rtp_rtcp_->SetRemoteSSRC((*receive_configs)[0].rtp.remote_ssrc);
2122 rtp_rtcp_->SetSSRC((*receive_configs)[0].rtp.local_ssrc); 2122 rtp_rtcp_->SetSSRC((*receive_configs)[0].rtp.local_ssrc);
2123 rtp_rtcp_->SetREMBStatus(true); 2123 rtp_rtcp_->SetREMBStatus(true);
2124 rtp_rtcp_->SetSendingStatus(true);
2125 rtp_rtcp_->SetRTCPStatus(RtcpMode::kReducedSize); 2124 rtp_rtcp_->SetRTCPStatus(RtcpMode::kReducedSize);
2126 } 2125 }
2127 2126
2128 void OnCallsCreated(Call* sender_call, Call* receiver_call) override { 2127 void OnCallsCreated(Call* sender_call, Call* receiver_call) override {
2129 sender_call_ = sender_call; 2128 sender_call_ = sender_call;
2130 } 2129 }
2131 2130
2132 static void BitrateStatsPollingThread(void* obj) { 2131 static void BitrateStatsPollingThread(void* obj) {
2133 static_cast<BweObserver*>(obj)->PollStats(); 2132 static_cast<BweObserver*>(obj)->PollStats();
2134 } 2133 }
(...skipping 2045 matching lines...) Expand 10 before | Expand all | Expand 10 after
4180 std::unique_ptr<VideoEncoder> encoder_; 4179 std::unique_ptr<VideoEncoder> encoder_;
4181 std::unique_ptr<VideoDecoder> decoder_; 4180 std::unique_ptr<VideoDecoder> decoder_;
4182 rtc::CriticalSection crit_; 4181 rtc::CriticalSection crit_;
4183 int recorded_frames_ GUARDED_BY(crit_); 4182 int recorded_frames_ GUARDED_BY(crit_);
4184 } test(this); 4183 } test(this);
4185 4184
4186 RunBaseTest(&test); 4185 RunBaseTest(&test);
4187 } 4186 }
4188 4187
4189 } // namespace webrtc 4188 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/rtp_stream_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698