Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: webrtc/call/flexfec_receive_stream_impl.cc

Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 receiver_(MaybeCreateFlexfecReceiver(config_, recovered_packet_receiver)), 131 receiver_(MaybeCreateFlexfecReceiver(config_, recovered_packet_receiver)),
132 rtp_receive_statistics_( 132 rtp_receive_statistics_(
133 ReceiveStatistics::Create(Clock::GetRealTimeClock())), 133 ReceiveStatistics::Create(Clock::GetRealTimeClock())),
134 rtp_rtcp_(CreateRtpRtcpModule(rtp_receive_statistics_.get(), 134 rtp_rtcp_(CreateRtpRtcpModule(rtp_receive_statistics_.get(),
135 config_.rtcp_send_transport, 135 config_.rtcp_send_transport,
136 rtt_stats)), 136 rtt_stats)),
137 process_thread_(process_thread) { 137 process_thread_(process_thread) {
138 LOG(LS_INFO) << "FlexfecReceiveStreamImpl: " << config_.ToString(); 138 LOG(LS_INFO) << "FlexfecReceiveStreamImpl: " << config_.ToString();
139 139
140 // RTCP reporting. 140 // RTCP reporting.
141 rtp_rtcp_->SetSendingMediaStatus(false);
142 rtp_rtcp_->SetRTCPStatus(config_.rtcp_mode); 141 rtp_rtcp_->SetRTCPStatus(config_.rtcp_mode);
143 rtp_rtcp_->SetSSRC(config_.local_ssrc); 142 rtp_rtcp_->SetSSRC(config_.local_ssrc);
144 process_thread_->RegisterModule(rtp_rtcp_.get(), RTC_FROM_HERE); 143 process_thread_->RegisterModule(rtp_rtcp_.get(), RTC_FROM_HERE);
145 } 144 }
146 145
147 FlexfecReceiveStreamImpl::~FlexfecReceiveStreamImpl() { 146 FlexfecReceiveStreamImpl::~FlexfecReceiveStreamImpl() {
148 LOG(LS_INFO) << "~FlexfecReceiveStreamImpl: " << config_.ToString(); 147 LOG(LS_INFO) << "~FlexfecReceiveStreamImpl: " << config_.ToString();
149 Stop(); 148 Stop();
150 process_thread_->DeRegisterModule(rtp_rtcp_.get()); 149 process_thread_->DeRegisterModule(rtp_rtcp_.get());
151 } 150 }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 started_ = false; 182 started_ = false;
184 } 183 }
185 184
186 // TODO(brandtr): Implement this member function when we have designed the 185 // TODO(brandtr): Implement this member function when we have designed the
187 // stats for FlexFEC. 186 // stats for FlexFEC.
188 FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const { 187 FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const {
189 return FlexfecReceiveStream::Stats(); 188 return FlexfecReceiveStream::Stats();
190 } 189 }
191 190
192 } // namespace webrtc 191 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698