Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 2740163002: Don't allocate any RTPSender object for a receive only RtpRtcp module (Closed)
Patch Set: Tolerate SetSendingMediaStatus(false) on receive-only streams. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 bool Sending() const; 90 bool Sending() const;
91 int32_t SetSendingStatus(const FeedbackState& feedback_state, 91 int32_t SetSendingStatus(const FeedbackState& feedback_state,
92 bool enabled); // combine the functions 92 bool enabled); // combine the functions
93 93
94 int32_t SetNackStatus(bool enable); 94 int32_t SetNackStatus(bool enable);
95 95
96 void SetTimestampOffset(uint32_t timestamp_offset); 96 void SetTimestampOffset(uint32_t timestamp_offset);
97 97
98 void SetLastRtpTime(uint32_t rtp_timestamp, int64_t capture_time_ms); 98 void SetLastRtpTime(uint32_t rtp_timestamp, int64_t capture_time_ms);
99 99
100 uint32_t SSRC() const;
danilchap 2017/03/16 15:41:12 Ssrc() (no need to introduce functions that break
nisse-webrtc 2017/03/17 09:29:44 In this case, I think consistency with existing me
danilchap 2017/03/17 09:49:38 I don't insist: local consistency is a good argume
101
100 void SetSSRC(uint32_t ssrc); 102 void SetSSRC(uint32_t ssrc);
101 103
102 void SetRemoteSSRC(uint32_t ssrc); 104 void SetRemoteSSRC(uint32_t ssrc);
103 105
104 int32_t SetCNAME(const char* cName); 106 int32_t SetCNAME(const char* cName);
105 107
106 int32_t AddMixedCNAME(uint32_t SSRC, const char* c_name); 108 int32_t AddMixedCNAME(uint32_t SSRC, const char* c_name);
107 109
108 int32_t RemoveMixedCNAME(uint32_t SSRC); 110 int32_t RemoveMixedCNAME(uint32_t SSRC);
109 111
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 typedef std::unique_ptr<rtcp::RtcpPacket> (RTCPSender::*BuilderFunc)( 284 typedef std::unique_ptr<rtcp::RtcpPacket> (RTCPSender::*BuilderFunc)(
283 const RtcpContext&); 285 const RtcpContext&);
284 // Map from RTCPPacketType to builder. 286 // Map from RTCPPacketType to builder.
285 std::map<uint32_t, BuilderFunc> builders_; 287 std::map<uint32_t, BuilderFunc> builders_;
286 288
287 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSender); 289 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSender);
288 }; 290 };
289 } // namespace webrtc 291 } // namespace webrtc
290 292
291 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_ 293 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698