Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: webrtc/video/full_stack_tests.cc

Issue 2739613003: Disable failing fullstack test with 15 thumbnail streams (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/video/video_quality_test.cc » ('j') | webrtc/video/video_quality_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <stdio.h> 10 #include <stdio.h>
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 video_params_low.video = kSimulcastVp8VideoLow; 500 video_params_low.video = kSimulcastVp8VideoLow;
501 501
502 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low), 502 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low),
503 DefaultVideoStream(video_params_medium), 503 DefaultVideoStream(video_params_medium),
504 DefaultVideoStream(video_params_high)}; 504 DefaultVideoStream(video_params_high)};
505 large_room.num_thumbnails = 5; 505 large_room.num_thumbnails = 5;
506 large_room.ss = {streams, 2, 1, 0}; 506 large_room.ss = {streams, 2, 1, 0};
507 RunTest(large_room); 507 RunTest(large_room);
508 } 508 }
509 509
510 TEST_F(FullStackTest, LargeRoomVP8_15thumb) { 510 #if defined(WEBRTC_ANDROID) || defined(WEBRTC_WIN)
511 // Fails on Android and win:
512 // https://bugs.chromium.org/p/webrtc/issues/detail?id=7301
513 #define MAYBE_LargeRoomVP8_50thumb DISABLED_LargeRoomVP8_50thumb
514 #else
515 #define MAYBE_LargeRoomVP8_50thumb LargeRoomVP8_50thumb
516 #endif
517
518 TEST_F(FullStackTest, MAYBE_LargeRoomVP8_15thumb) {
511 VideoQualityTest::Params large_room; 519 VideoQualityTest::Params large_room;
512 large_room.call.send_side_bwe = true; 520 large_room.call.send_side_bwe = true;
513 large_room.video = kSimulcastVp8VideoHigh; 521 large_room.video = kSimulcastVp8VideoHigh;
514 large_room.analyzer = {"largeroom_15thumb", 0.0, 0.0, 522 large_room.analyzer = {"largeroom_15thumb", 0.0, 0.0,
515 kFullStackTestDurationSecs}; 523 kFullStackTestDurationSecs};
516 large_room.pipe.loss_percent = 0; 524 large_room.pipe.loss_percent = 0;
517 large_room.pipe.queue_delay_ms = 100; 525 large_room.pipe.queue_delay_ms = 100;
518 VideoQualityTest::Params video_params_high; 526 VideoQualityTest::Params video_params_high;
519 video_params_high.video = kSimulcastVp8VideoHigh; 527 video_params_high.video = kSimulcastVp8VideoHigh;
520 VideoQualityTest::Params video_params_medium; 528 VideoQualityTest::Params video_params_medium;
521 video_params_medium.video = kSimulcastVp8VideoMedium; 529 video_params_medium.video = kSimulcastVp8VideoMedium;
522 VideoQualityTest::Params video_params_low; 530 VideoQualityTest::Params video_params_low;
523 video_params_low.video = kSimulcastVp8VideoLow; 531 video_params_low.video = kSimulcastVp8VideoLow;
524 532
525 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low), 533 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low),
526 DefaultVideoStream(video_params_medium), 534 DefaultVideoStream(video_params_medium),
527 DefaultVideoStream(video_params_high)}; 535 DefaultVideoStream(video_params_high)};
528 large_room.num_thumbnails = 15; 536 large_room.num_thumbnails = 15;
529 large_room.ss = {streams, 2, 1, 0}; 537 large_room.ss = {streams, 2, 1, 0};
530 RunTest(large_room); 538 RunTest(large_room);
531 } 539 }
532 540
533 #if defined(WEBRTC_ANDROID) || defined(WEBRTC_WIN)
534 // Fails on Android and win:
535 // https://bugs.chromium.org/p/webrtc/issues/detail?id=7301
536 #define MAYBE_LargeRoomVP8_50thumb DISABLED_LargeRoomVP8_50thumb
537 #else
538 #define MAYBE_LargeRoomVP8_50thumb LargeRoomVP8_50thumb
539 #endif
540
541 TEST_F(FullStackTest, MAYBE_LargeRoomVP8_50thumb) { 541 TEST_F(FullStackTest, MAYBE_LargeRoomVP8_50thumb) {
542 VideoQualityTest::Params large_room; 542 VideoQualityTest::Params large_room;
543 large_room.call.send_side_bwe = true; 543 large_room.call.send_side_bwe = true;
544 large_room.video = kSimulcastVp8VideoHigh; 544 large_room.video = kSimulcastVp8VideoHigh;
545 large_room.analyzer = {"largeroom_50thumb", 0.0, 0.0, 545 large_room.analyzer = {"largeroom_50thumb", 0.0, 0.0,
546 kFullStackTestDurationSecs}; 546 kFullStackTestDurationSecs};
547 large_room.pipe.loss_percent = 0; 547 large_room.pipe.loss_percent = 0;
548 large_room.pipe.queue_delay_ms = 100; 548 large_room.pipe.queue_delay_ms = 100;
549 VideoQualityTest::Params video_params_high; 549 VideoQualityTest::Params video_params_high;
550 video_params_high.video = kSimulcastVp8VideoHigh; 550 video_params_high.video = kSimulcastVp8VideoHigh;
551 VideoQualityTest::Params video_params_medium; 551 VideoQualityTest::Params video_params_medium;
552 video_params_medium.video = kSimulcastVp8VideoMedium; 552 video_params_medium.video = kSimulcastVp8VideoMedium;
553 VideoQualityTest::Params video_params_low; 553 VideoQualityTest::Params video_params_low;
554 video_params_low.video = kSimulcastVp8VideoLow; 554 video_params_low.video = kSimulcastVp8VideoLow;
555 555
556 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low), 556 std::vector<VideoStream> streams = {DefaultVideoStream(video_params_low),
557 DefaultVideoStream(video_params_medium), 557 DefaultVideoStream(video_params_medium),
558 DefaultVideoStream(video_params_high)}; 558 DefaultVideoStream(video_params_high)};
559 large_room.num_thumbnails = 50; 559 large_room.num_thumbnails = 50;
560 large_room.ss = {streams, 2, 1, 0}; 560 large_room.ss = {streams, 2, 1, 0};
561 RunTest(large_room); 561 RunTest(large_room);
562 } 562 }
563 563
564 564
565 } // namespace webrtc 565 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/video/video_quality_test.cc » ('j') | webrtc/video/video_quality_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698