PRESUBMIT.py - Issue 2737963003: Update pylintrc to catch more style violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2737963003: Update pylintrc to catch more style violations. (Closed)

Patch Set: Added OWNERS Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index efa80fab4ff47f1bc8beb28ed88db9d94c84f75c..24eff148e8edd10478aca0c11163d7b303c135fe 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -526,6 +526,7 @@ def _CommonChecks(input_api, output_api):

black_list=(r'^base[\\\/].*\.py$',

r'^build[\\\/].*\.py$',

r'^buildtools[\\\/].*\.py$',

+ r'^infra[\\\/].*\.py$',

r'^ios[\\\/].*\.py$',

r'^out.*[\\\/].*\.py$',

r'^testing[\\\/].*\.py$',

@@ -535,10 +536,6 @@ def _CommonChecks(input_api, output_api):

r'^tools-webrtc[\\\/]mb[\\\/].*\.py$',

r'^tools-webrtc[\\\/]valgrind[\\\/].*\.py$',

r'^xcodebuild.*[\\\/].*\.py$',),

- disabled_warnings=['F0401', # Failed to import x

- 'E0611', # No package y in x

- 'W0232', # Class has no __init__ method

- ],

pylintrc='pylintrc'))

# TODO(nisse): talk/ is no more, so make below checks simpler?

« no previous file with comments | « OWNERS ('k') | pylintrc » ('j') | no next file with comments »