Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: tools-webrtc/check_package_boundaries_test.py

Issue 2737233003: Revert of PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools-webrtc/check_package_boundaries.py ('k') | tools-webrtc/get_landmines.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 3 # Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
4 # 4 #
5 # Use of this source code is governed by a BSD-style license 5 # Use of this source code is governed by a BSD-style license
6 # that can be found in the LICENSE file in the root of the source 6 # that can be found in the LICENSE file in the root of the source
7 # tree. An additional intellectual property rights grant can be found 7 # tree. An additional intellectual property rights grant can be found
8 # in the file PATENTS. All contributing project authors may 8 # in the file PATENTS. All contributing project authors may
9 # be found in the AUTHORS file in the root of the source tree. 9 # be found in the AUTHORS file in the root of the source tree.
10 10
(...skipping 12 matching lines...) Expand all
23 def ReadPylFile(file_path): 23 def ReadPylFile(file_path):
24 with open(file_path) as f: 24 with open(file_path) as f:
25 return ast.literal_eval(f.read()) 25 return ast.literal_eval(f.read())
26 26
27 27
28 class Logger(object): 28 class Logger(object):
29 def __init__(self, test_dir): 29 def __init__(self, test_dir):
30 self.messages = [] 30 self.messages = []
31 self.test_dir = test_dir 31 self.test_dir = test_dir
32 32
33 def Log(self, build_file_path, line_number, target_name, source_file, 33 def log(self, build_file_path, line_number, target_name, source_file,
34 subpackage): 34 subpackage):
35 build_file_path = os.path.relpath(build_file_path, self.test_dir) 35 build_file_path = os.path.relpath(build_file_path, self.test_dir)
36 build_file_path = build_file_path.replace(os.path.sep, '/') 36 build_file_path = build_file_path.replace(os.path.sep, '/')
37 self.messages.append([build_file_path, line_number, target_name, 37 self.messages.append([build_file_path, line_number, target_name,
38 source_file, subpackage]) 38 source_file, subpackage])
39 39
40 40
41 class UnitTest(unittest.TestCase): 41 class UnitTest(unittest.TestCase):
42 def RunTest(self, test_dir, check_all_build_files=False): 42 def RunTest(self, test_dir, check_all_build_files=False):
43 logger = Logger(test_dir) 43 logger = Logger(test_dir)
44 build_files = [os.path.join(test_dir, 'BUILD.gn')] 44 build_files = [os.path.join(test_dir, 'BUILD.gn')]
45 if check_all_build_files: 45 if check_all_build_files:
46 build_files = None 46 build_files = None
47 CheckPackageBoundaries(test_dir, logger, build_files) 47 CheckPackageBoundaries(test_dir, logger, build_files)
48 expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl')) 48 expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl'))
49 self.assertListEqual(sorted(expected_messages), sorted(logger.messages)) 49 self.assertListEqual(sorted(expected_messages), sorted(logger.messages))
50 50
51 def testNoErrors(self): 51 def test_no_errors(self):
52 self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors')) 52 self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors'))
53 53
54 def testMultipleErrorsSingleTarget(self): 54 def test_multiple_errors_single_target(self):
55 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target')) 55 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target'))
56 56
57 def testMultipleErrorsMultipleTargets(self): 57 def test_multiple_errors_multiple_targets(self):
58 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets')) 58 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets'))
59 59
60 def testCommonPrefix(self): 60 def test_common_prefix(self):
61 self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix')) 61 self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix'))
62 62
63 def testAllBuildFiles(self): 63 def test_all_build_files(self):
64 self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True) 64 self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True)
65 65
66 66
67 if __name__ == '__main__': 67 if __name__ == '__main__':
68 unittest.main() 68 unittest.main()
OLDNEW
« no previous file with comments | « tools-webrtc/check_package_boundaries.py ('k') | tools-webrtc/get_landmines.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698