Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: webrtc/base/rate_limiter.h

Issue 2735423002: Mark |Clock*| as |const Clock*| (for some CongestionController and BWE related modules) (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/rate_limiter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_BASE_RATE_LIMITER_H_ 11 #ifndef WEBRTC_BASE_RATE_LIMITER_H_
12 #define WEBRTC_BASE_RATE_LIMITER_H_ 12 #define WEBRTC_BASE_RATE_LIMITER_H_
13 13
14 #include <limits> 14 #include <limits>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/base/criticalsection.h" 17 #include "webrtc/base/criticalsection.h"
18 #include "webrtc/base/rate_statistics.h" 18 #include "webrtc/base/rate_statistics.h"
19 19
20 namespace webrtc { 20 namespace webrtc {
21 21
22 class Clock; 22 class Clock;
23 23
24 // Class used to limit a bitrate, making sure the average does not exceed a 24 // Class used to limit a bitrate, making sure the average does not exceed a
25 // maximum as measured over a sliding window. This class is thread safe; all 25 // maximum as measured over a sliding window. This class is thread safe; all
26 // methods will acquire (the same) lock befeore executing. 26 // methods will acquire (the same) lock befeore executing.
27 class RateLimiter { 27 class RateLimiter {
28 public: 28 public:
29 RateLimiter(Clock* clock, int64_t max_window_ms); 29 RateLimiter(const Clock* clock, int64_t max_window_ms);
30 ~RateLimiter(); 30 ~RateLimiter();
31 31
32 // Try to use rate to send bytes. Returns true on success and if so updates 32 // Try to use rate to send bytes. Returns true on success and if so updates
33 // current rate. 33 // current rate.
34 bool TryUseRate(size_t packet_size_bytes); 34 bool TryUseRate(size_t packet_size_bytes);
35 35
36 // Set the maximum bitrate, in bps, that this limiter allows to send. 36 // Set the maximum bitrate, in bps, that this limiter allows to send.
37 void SetMaxRate(uint32_t max_rate_bps); 37 void SetMaxRate(uint32_t max_rate_bps);
38 38
39 // Set the window size over which to measure the current bitrate. 39 // Set the window size over which to measure the current bitrate.
40 // For example, irt retransmissions, this is typically the RTT. 40 // For example, irt retransmissions, this is typically the RTT.
41 // Returns true on success and false if window_size_ms is out of range. 41 // Returns true on success and false if window_size_ms is out of range.
42 bool SetWindowSize(int64_t window_size_ms); 42 bool SetWindowSize(int64_t window_size_ms);
43 43
44 private: 44 private:
45 Clock* const clock_; 45 const Clock* const clock_;
46 rtc::CriticalSection lock_; 46 rtc::CriticalSection lock_;
47 RateStatistics current_rate_ GUARDED_BY(lock_); 47 RateStatistics current_rate_ GUARDED_BY(lock_);
48 int64_t window_size_ms_ GUARDED_BY(lock_); 48 int64_t window_size_ms_ GUARDED_BY(lock_);
49 uint32_t max_rate_bps_ GUARDED_BY(lock_); 49 uint32_t max_rate_bps_ GUARDED_BY(lock_);
50 50
51 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RateLimiter); 51 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RateLimiter);
52 }; 52 };
53 53
54 } // namespace webrtc 54 } // namespace webrtc
55 55
56 #endif // WEBRTC_BASE_RATE_LIMITER_H_ 56 #endif // WEBRTC_BASE_RATE_LIMITER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/rate_limiter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698