Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.h

Issue 2735303004: Add video codec setting to AppRTCMobile on iOS. (Closed)
Patch Set: Fix AppRTCMobile on Mac. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 * Stores the provided video resolution media constraint string into the store. 42 * Stores the provided video resolution media constraint string into the store.
43 * 43 *
44 * If the provided constraint is no part of the available video resolutions 44 * If the provided constraint is no part of the available video resolutions
45 * the store operation will not be executed and NO will be returned. 45 * the store operation will not be executed and NO will be returned.
46 * @param constraint the string to be stored. 46 * @param constraint the string to be stored.
47 * @return YES/NO depending on success. 47 * @return YES/NO depending on success.
48 */ 48 */
49 - (BOOL)storeVideoResoultionConstraint:(NSString *)constraint; 49 - (BOOL)storeVideoResoultionConstraint:(NSString *)constraint;
50 50
51 /** 51 /**
52 * Returns array of available video codecs.
53 */
54 - (NSArray<NSString *> *)availableVideoCodecs;
55
56 /**
57 * Returns current video codec setting from store if present.
daniela-webrtc 2017/03/20 13:10:06 This documentation can be improved slightly. Sugge
58 */
59 - (NSString *)currentVideoCodecSettingFromStore;
60
61 /**
62 * Stores the provided video codec setting into the store.
63 *
64 * If the provided constraint is not part of the available video codecs
daniela-webrtc 2017/03/20 13:10:07 provided constraint -> provided video codec
65 * the store operation will not be executed and NO will be returned.
66 * @param video codec settings the string to be stored.
67 * @return YES/NO depending on success.
68 */
69 - (BOOL)storeVideoCodecSetting:(NSString *)videoCodec;
70
71 /**
52 * Converts the current media constraints from store into dictionary with RTCMed iaConstraints 72 * Converts the current media constraints from store into dictionary with RTCMed iaConstraints
53 * values. 73 * values.
54 * 74 *
55 * @return NSDictionary with RTC width and height parameters 75 * @return NSDictionary with RTC width and height parameters
56 */ 76 */
57 - (nullable NSDictionary *)currentMediaConstraintFromStoreAsRTCDictionary; 77 - (nullable NSDictionary *)currentMediaConstraintFromStoreAsRTCDictionary;
58 78
59 /** 79 /**
60 * Returns current max bitrate setting from store if present. 80 * Returns current max bitrate setting from store if present.
61 */ 81 */
62 - (nullable NSNumber *)currentMaxBitrateSettingFromStore; 82 - (nullable NSNumber *)currentMaxBitrateSettingFromStore;
63 83
64 /** 84 /**
65 * Stores the provided bitrate value into the store. 85 * Stores the provided bitrate value into the store.
66 * 86 *
67 * @param bitrate NSNumber representation of the max bitrate value. 87 * @param bitrate NSNumber representation of the max bitrate value.
68 */ 88 */
69 - (void)storeMaxBitrateSetting:(nullable NSNumber *)bitrate; 89 - (void)storeMaxBitrateSetting:(nullable NSNumber *)bitrate;
70 90
71 @end 91 @end
72 NS_ASSUME_NONNULL_END 92 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698