Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: webrtc/pc/webrtcsession.h

Issue 2732663004: Rename OnIceConnectionChange to OnIceConnectionStateChange for consistency with the WebRTC 1.0 stan… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // Maximum number of received video streams that will be processed by webrtc 76 // Maximum number of received video streams that will be processed by webrtc
77 // even if they are not signalled beforehand. 77 // even if they are not signalled beforehand.
78 extern const int kMaxUnsignalledRecvStreams; 78 extern const int kMaxUnsignalledRecvStreams;
79 79
80 // ICE state callback interface. 80 // ICE state callback interface.
81 class IceObserver { 81 class IceObserver {
82 public: 82 public:
83 IceObserver() {} 83 IceObserver() {}
84 // Called any time the IceConnectionState changes 84 // Called any time the IceConnectionState changes
85 // TODO(honghaiz): Change the name to OnIceConnectionStateChange so as to 85 virtual void OnIceConnectionStateChange(
86 // conform to the w3c standard.
87 virtual void OnIceConnectionChange(
88 PeerConnectionInterface::IceConnectionState new_state) {} 86 PeerConnectionInterface::IceConnectionState new_state) {}
89 // Called any time the IceGatheringState changes 87 // Called any time the IceGatheringState changes
90 virtual void OnIceGatheringChange( 88 virtual void OnIceGatheringChange(
91 PeerConnectionInterface::IceGatheringState new_state) {} 89 PeerConnectionInterface::IceGatheringState new_state) {}
92 // New Ice candidate have been found. 90 // New Ice candidate have been found.
93 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0; 91 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
94 92
95 // Some local ICE candidates have been removed. 93 // Some local ICE candidates have been removed.
96 virtual void OnIceCandidatesRemoved( 94 virtual void OnIceCandidatesRemoved(
97 const std::vector<cricket::Candidate>& candidates) = 0; 95 const std::vector<cricket::Candidate>& candidates) = 0;
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
634 632
635 #ifdef HAVE_QUIC 633 #ifdef HAVE_QUIC
636 std::unique_ptr<QuicDataTransport> quic_data_transport_; 634 std::unique_ptr<QuicDataTransport> quic_data_transport_;
637 #endif // HAVE_QUIC 635 #endif // HAVE_QUIC
638 636
639 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession); 637 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession);
640 }; 638 };
641 } // namespace webrtc 639 } // namespace webrtc
642 640
643 #endif // WEBRTC_PC_WEBRTCSESSION_H_ 641 #endif // WEBRTC_PC_WEBRTCSESSION_H_
OLDNEW
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698