Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: .gn

Issue 2729243003: Reland of Setting is_component_build to false by default (Closed)
Patch Set: Allowing component builds if built with chromium Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools-webrtc/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 2070fa86d34409cd45ecd491b6f31c0a72b2ab56..547ca848db5da0d15345c463decfe92767ee6e61 100644
--- a/.gn
+++ b/.gn
@@ -51,3 +51,14 @@ check_targets = [
# to force additional review for new uses of exec_script, which is strongly
# discouraged except for gypi_to_gn calls.
exec_script_whitelist = build_dotfile_settings.exec_script_whitelist
+
+default_args = {
+ # Webrtc does not support component builds because we are not using the
+ # template "component" but we rely directly on "rtc_static_library" and
+ # "rtc_shared_library". This means that we cannot use the chromium default
+ # value for this argument.
+ # This also means that the user can override this value using --args or
+ # the args.gn file but this setting will be ignored because we don't support
+ # component builds.
+ is_component_build = false
+}
« no previous file with comments | « no previous file | tools-webrtc/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698