Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: webrtc/audio/audio_send_stream.cc

Issue 2725823002: Move delay_based_bwe_ into CongestionController (Closed)
Patch Set: More refactoring + UTs moved. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 } else if (extension.uri == RtpExtension::kTransportSequenceNumberUri) { 79 } else if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
80 channel_proxy_->EnableSendTransportSequenceNumber(extension.id); 80 channel_proxy_->EnableSendTransportSequenceNumber(extension.id);
81 congestion_controller->EnablePeriodicAlrProbing(true); 81 congestion_controller->EnablePeriodicAlrProbing(true);
82 bandwidth_observer_.reset(congestion_controller->GetBitrateController() 82 bandwidth_observer_.reset(congestion_controller->GetBitrateController()
83 ->CreateRtcpBandwidthObserver()); 83 ->CreateRtcpBandwidthObserver());
84 } else { 84 } else {
85 RTC_NOTREACHED() << "Registering unsupported RTP extension."; 85 RTC_NOTREACHED() << "Registering unsupported RTP extension.";
86 } 86 }
87 } 87 }
88 channel_proxy_->RegisterSenderCongestionControlObjects( 88 channel_proxy_->RegisterSenderCongestionControlObjects(
89 congestion_controller->pacer(), 89 congestion_controller->pacer(), congestion_controller, packet_router,
minyue-webrtc 2017/03/02 19:53:58 should the 2nd arg be an FeedbackAdaptor?
elad.alon_webrtc.org 2017/03/08 18:25:09 As agreed with Stefan, CongestionController is now
90 congestion_controller->GetTransportFeedbackObserver(), packet_router,
91 bandwidth_observer_.get()); 90 bandwidth_observer_.get());
92 if (!SetupSendCodec()) { 91 if (!SetupSendCodec()) {
93 LOG(LS_ERROR) << "Failed to set up send codec state."; 92 LOG(LS_ERROR) << "Failed to set up send codec state.";
94 } 93 }
95 } 94 }
96 95
97 AudioSendStream::~AudioSendStream() { 96 AudioSendStream::~AudioSendStream() {
98 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 97 RTC_DCHECK(thread_checker_.CalledOnValidThread());
99 LOG(LS_INFO) << "~AudioSendStream: " << config_.ToString(); 98 LOG(LS_INFO) << "~AudioSendStream: " << config_.ToString();
100 channel_proxy_->DeRegisterExternalTransport(); 99 channel_proxy_->DeRegisterExternalTransport();
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 LOG(LS_WARNING) << "SetVADStatus() failed."; 378 LOG(LS_WARNING) << "SetVADStatus() failed.";
380 return false; 379 return false;
381 } 380 }
382 } 381 }
383 } 382 }
384 return true; 383 return true;
385 } 384 }
386 385
387 } // namespace internal 386 } // namespace internal
388 } // namespace webrtc 387 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698